1531156 - RTCPeerConnection.currentRemote/LocalDescription can have the wrong type

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P2)

Description

[Byron Campen [:bwc]]

https://jsfiddle.net/jevrh87z/

The problem is that the type for currentRemoteDescription is set in setRemoteDescription, but it should only be set when negotiation finishes, because currentRemoteDescription is the currently negotiated remote description.

https://searchfox.org/mozilla-central/rev/2a6f3dde00801374d3b2a704232de54a132af389/dom/media/PeerConnection.jsm#1014

There is a similar problem with currentLocalDescription.

https://searchfox.org/mozilla-central/rev/2a6f3dde00801374d3b2a704232de54a132af389/dom/media/PeerConnection.jsm#945

Comment 1

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d2693f9264438efc32f95eb6aad84716ce267f5b

Comment 2

[Byron Campen [:bwc]]

Attachment: Bug 1531156 - Part 0: Re-enable a test-case.

Depends on D21557

Comment 3

[Byron Campen [:bwc]]

Attachment: Bug 1531156 - Part 1: Remember our role from the previous negotiation so we can use the right type for getCurrentRemote/LocalDescription.

Depends on D22206

Comment 4

[Byron Campen [:bwc]]

Attachment: Bug 1531156 - Part 2: Re-enable another test case that this fixed.

Depends on D22207

Comment 5

[Byron Campen [:bwc]]

Attachment: Bug 1531156 - Part 2: Some code simplification that part 1 lets us do.

Depends on D22208

Comment 6

[Byron Campen [:bwc]]

Ping for review on part 3.

Comment 7

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fe56c7af829b5489b926840e79ca766e435d5a09

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/52fd3c1c9615
https://hg.mozilla.org/mozilla-central/rev/41c4e3fc6f9d
https://hg.mozilla.org/mozilla-central/rev/c1e7e2cb32cd

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/integration/autoland/rev/52fd3c1c9615f5cd5b7e14a656c01b629d1788cc
https://hg.mozilla.org/integration/autoland/rev/41c4e3fc6f9d68b5a88e6002f2d6d9cf27199503
https://hg.mozilla.org/integration/autoland/rev/c1e7e2cb32cdd90af697743ce7dea3303a249977