1531175 - windows/aarch64 - tests\jit-test\jit-test\tests\self-test\assertRecoveredOnBailout-1.js | Hit MOZ_CRASH(Cannot test assertRecoveredOnBailout) at z:/build/build/src/js/src/shell/js.cpp:3695 (code -1073741795, args "") [0.2 s]

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Treeherder Bug Filer]

#[markdown(off)]
Filed by: egao [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=230809597&repo=try

https://queue.taskcluster.net/v1/task/dryYij1hRVC-m5L8i3yZDw/runs/0/artifacts/public/logs/live_backing.log

Observed during windows10-aarch64/opt-jittest.

Context:
18:06:48 WARNING - TEST-UNEXPECTED-FAIL | tests\jit-test\jit-test\tests\self-test\assertRecoveredOnBailout-1.js | Hit MOZ_CRASH(Cannot test assertRecoveredOnBailout) at z:/build/build/src/js/src/shell/js.cpp:3695 (code -1073741795, args "") [0.2 s]
18:06:48 INFO - {"action": "test_start", "jitflags": "", "pid": 9692, "source": "jittests", "test": "self-test\\assertRecoveredOnBailout-1.js", "thread": "main", "time": 1551290807.819}
18:06:48 INFO - {"action": "test_end", "extra": {"jitflags": ""}, "jitflags": "", "message": "Hit MOZ_CRASH(Cannot test assertRecoveredOnBailout) at z:/build/build/src/js/src/shell/js.cpp:3695", "pid": 9692, "source": "jittests", "status": "FAIL", "test": "self-test\\assertRecoveredOnBailout-1.js", "thread": "main", "time": 1551290808.047}
18:06:48 INFO - INFO exit-status : -1073741795
18:06:48 INFO - INFO timed-out : False
18:06:48 INFO - INFO stderr 2> Hit MOZ_CRASH(Cannot test assertRecoveredOnBailout) at z:/build/build/src/js/src/shell/js.cpp:3695

Comment 1

[Intermittent Failures Robot]

2 failures in 2981 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 2

Platform breakdown:

• windows10-aarch64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1531175&startday=2019-02-25&endday=2019-03-03&tree=all

Comment 2

[Intermittent Failures Robot]

1 failures in 2818 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1

Platform breakdown:

• windows10-aarch64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1531175&startday=2019-03-04&endday=2019-03-10&tree=all

Comment 3

[Geoff Brown [:gbrown]]

I confirmed that this is still easily reproducible today:

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=3ce1eb12c3e95328a9410d95e83162e886f066db

If this test is skipped, the windows/aarch64 jittest task is green more often than not:

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=b6b3f88a33ba69afc94351ecc238efa65f5abf3e

Comment 4

[Intermittent Failures Robot]

2 failures in 2673 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 2

Platform breakdown:

• windows10-aarch64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1531175&startday=2019-04-15&endday=2019-04-21&tree=all

Comment 5

[Sean Stangl [:sstangl]]

I can't reproduce it, but I'll take a look. It's crashing in test setup code that doesn't use jitcode yet.

Comment 6

[Nicolas B. Pierron [:nbp]]

From my point of view, the issue is in the test harness, which does not interpret a an expected crashing test as an expected case. Not in the test case, which is crashing as expected.

My blind guess would be to look around the remote worker if any, or around this handling of the error code:
https://searchfox.org/mozilla-central/source/js/src/tests/lib/jittests.py#498-514

My guess would be that we need to add the following case:

    if sys.platform == 'win32' and rc == 29 - 2 ** 30:
      return True

and maybe insert a test for Aarch64.

Comment 7

[Nicolas B. Pierron [:nbp]]

Attachment: Bug 1531175 - jit-test ARM64: Do not skip crash-tests.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7917e1acc57
jit-test ARM64: Do not skip crash-tests. r=iain

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/d7917e1acc57