Closed
Bug 1531302
Opened 6 years ago
Closed 6 years ago
Port bug 1453456 - mailnews/base/search/src/nsMsgImapSearch.cpp:114:21: error: no matching function for call to 'NS_IsAscii'
Categories
(MailNews Core :: General, task)
MailNews Core
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 67.0
People
(Reporter: jorgk-bmo, Assigned: jorgk-bmo)
Details
Attachments
(1 file)
|
4.55 KB,
patch
|
benc
:
review+
|
Details | Diff | Splinter Review |
18e52bd7c3ad Jeff Walden — Bug 1453456 - Remove nsCRT::IsAscii(null-terminated string) in favor of mozilla::IsAsciiNullTerminated. r=froydnj
e4565e7ddcb0 Jeff Walden — Bug 1453456 - Remove nsCRT::IsAscii(char16_t) in favor of mozilla::IsAscii. r=froydnj
|
Assignee | |
Comment 1•6 years ago
|
||
Assignee: nobody → jorgk
|
|
Assignee | |
Comment 2•6 years ago
|
||
Comment on attachment 9047365 [details] [diff] [review]
1531302-NS_IsAscii.patch
This was done in a hurry. I think it's right.
Attachment #9047365 -
Flags: review?(benc)
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/5258b9d5bddb
Port bug 1453456: replace use of NS_IsAscii. rs=bustage-fix
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•6 years ago
|
Target Milestone: --- → Thunderbird 67.0
|
||
Comment 4•6 years ago
|
||
Comment on attachment 9047365 [details] [diff] [review]
1531302-NS_IsAscii.patch
Review of attachment 9047365 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me.
Attachment #9047365 -
Flags: review?(benc) → review+
|
||
Updated•6 years ago
|
Type: enhancement → task
You need to log in
before you can comment on or make changes to this bug.
Description
•