1531387 - [wpt-sync] Sync PR 15535 - Updates RTCIceTransport to standard state API.

Status: RESOLVED FIXED

(Core :: WebRTC, enhancement, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 15535 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15535
Details from upstream follow.

Seth Hampson <[e-mail]> wrote:

Updates RTCIceTransport to standard state API.

The underlying P2PTransportChannel has been updated to the spec
compliant RTCIceTransportState. This change updates the standalone
RTCIceTransport to use this.

Bug: 928081
Change-Id: Ia127c0f5473e49b8c48e8595f8381aa2542e7e2e
Reviewed-on: https://chromium-review.googlesource.com/c/1483943
Reviewed-by: Steve Anton \<[e-mail]>
Commit-Queue: Seth Hampson \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#635652}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=2956ddf90ede8558972de851c185fbfbafbbbb10

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Ran 1 tests and 29 subtests
OK     : 1
FAIL   : 29

New tests that have failures or other problems:
/webrtc/RTCIceTransport-extension.https.html
    RTCIceTransport constructor does not throw: FAIL[linux32-debug,linux64-debug,linux64-opt]
    RTCIceTransport initial properties are set: FAIL[linux32-debug,linux64-debug,linux64-opt]
    Selected candidate pair changes once the RTCIceTransports connect.: FAIL[linux32-debug,linux64-debug,linux64-opt]
    Two RTCIceTransports configured with the controlled role resolve the conflict in band and still connect.: FAIL[linux32-debug,linux64-debug,linux64-opt]
    Two RTCIceTransports configured with the controlling role resolve the conflict in band and still connect.: FAIL[linux32-debug,linux64-debug,linux64-opt]
    Two RTCIceTransports connect to each other: FAIL[linux32-debug,linux64-debug,linux64-opt]
    addRemoteCandidate() throws if closed: FAIL[linux32-debug,linux64-debug,linux64-opt]
    addRemoteCandidate() throws on invalid candidate: FAIL[linux32-debug,linux64-debug,linux64-opt]
    addRemoteCandidate() transitions state to 'checking' if start() had been called before: FAIL[linux32-debug,linux64-debug,linux64-opt]
    eventually transition gatheringState to 'complete': FAIL[linux32-debug,linux64-debug,linux64-opt]
    gather() returns at least one host candidate: FAIL[linux32-debug,linux64-debug,linux64-opt]
    gather() returns no candidates with { gatherPolicy: 'relay'} and no turn servers: FAIL[linux32-debug,linux64-debug,linux64-opt]
    gather() throws if called twice: FAIL[linux32-debug,linux64-debug,linux64-opt]
    gather() throws if closed: FAIL[linux32-debug,linux64-debug,linux64-opt]
    gather() transitions gatheringState to 'gathering': FAIL[linux32-debug,linux64-debug,linux64-opt]
    gather() with 2 stun servers should succeed: FAIL[linux32-debug,linux64-debug,linux64-opt]
    gather() with one turns server, one turn server, username, credential should succeed: FAIL[linux32-debug,linux64-debug,linux64-opt]
    gather() with { iceServers: null } should throw TypeError: FAIL[linux32-debug,linux64-debug,linux64-opt]
    gather() with { iceServers: undefined } should succeed: FAIL[linux32-debug,linux64-debug,linux64-opt]
    getSelectedCandidatePair() returns null once the RTCIceTransport is stopped.: FAIL[linux32-debug,linux64-debug,linux64-opt]
    onicecandidate fires with null candidate before gatheringState transitions to 'complete': FAIL[linux32-debug,linux64-debug,linux64-opt]
    start() does not transition state to 'checking' if no remote candidates added: FAIL[linux32-debug,linux64-debug,linux64-opt]
    start() flushes remote candidates and transitions state to 'new' if later called with different remote parameters: FAIL[linux32-debug,linux64-debug,linux64-opt]
    start() sets role attribute to 'controlling': FAIL[linux32-debug,linux64-debug,linux64-opt]
    start() throws if closed: FAIL[linux32-debug,linux64-debug,linux64-opt]
    start() throws if later called with a different role: FAIL[linux32-debug,linux64-debug,linux64-opt]
    start() throws if usernameFragment or password not set: FAIL[linux32-debug,linux64-debug,linux64-opt]
    start() transitions state to 'checking' if one remote candidate had been added: FAIL[linux32-debug,linux64-debug,linux64-opt]
    start() with default role sets role attribute to 'controlled': FAIL[linux32-debug,linux64-debug,linux64-opt]

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4baeae24ce99
[wpt PR 15535] - Updates RTCIceTransport to standard state API., a=testonly

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/4baeae24ce99