Closed
Bug 1531399
Opened 5 years ago
Closed 5 years ago
Port Bug 1525319 - Removing context from OnStartRequest/OnStopRequest/OnDataAvailable
Categories
(SeaMonkey :: General, enhancement)
SeaMonkey
General
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.64
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
Attachments
(2 files)
|
2.95 KB,
patch
|
frg
:
review+
|
Details | Diff | Splinter Review |
|
1.20 KB,
patch
|
frg
:
review+
|
Details | Diff | Splinter Review |
Bug 1525319 - Removing context from OnStartRequest/OnStopRequest/OnDataAvailable will cause / has caused bustage
Attachment #9047416 -
Flags: review?(frgrahl)
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/c65e18defe58
Port Bug 1525319 [Removing context from OnStartRequest/OnStopRequest/OnDataAvailable} to SeaMonkey. r=frg
https://hg.mozilla.org/comm-central/rev/c9fb391a9aaa
Follow-up function parameter alignment fix. r=frg
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
|
||
Comment 3•5 years ago
|
||
Comment on attachment 9047416 [details] [diff] [review] Port context removal looks good. r+. > +nsFeedSniffer::OnDataAvailable(nsIRequest* request, Parameters should be aligned to 80 chars to be consistent. NIT fix from Bill in a follow-up
Attachment #9047416 -
Flags: review?(frgrahl) → review+
|
|
||
Comment 4•5 years ago
|
||
Bill did the same fix yesterday but fixed the alignment. Just took this for a follow-up nit fix.
https://hg.mozilla.org/comm-central/rev/c9fb391a9aaaf5bd4a0491dc184a82a0a88e7e28
Attachment #9047971 -
Flags: review+
|
|
||
Updated•5 years ago
|
Target Milestone: --- → seamonkey2.64
You need to log in
before you can comment on or make changes to this bug.
Description
•