1531400 - Missing bottom border on netmonitor table's header

Status: RESOLVED FIXED

(DevTools :: Netmonitor, enhancement, P2)

Description

[Alexandre Poirot [:ochameau]]

Because border doesn't work for <thead> and <tr>, we are missing the bottom border on the <thead> element of the netmonitor.
This bottom border comes from .devtools-toolbar rule.

I think that, unfortunately, we need dedicated CSS in order to address that.
We have to apply a bottom border to all the <td> elements.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1531400 - Restore bottom border on netmonitor header row.

Because <thead> and <tr> don't support border, we have to apply the style
to <td>.

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Alex, just to note that I left a comment in phabricator.
https://phabricator.services.mozilla.com/D21556

Honza

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Taking this bug as discussed with Alex.

Honza

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: Bug 1531400 - Missing bottom border on netmonitor table's header; r=ladybenko

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c0c0b342f39e
Missing bottom border on netmonitor table's header; r=ladybenko

Comment 6

[Dorel Luca [:dluca]]

Backed out changeset c0c0b342f39e (bug 1531400) for DevTools failures in devtools/client/netmonitor/test/browser_net_autoscroll.js

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=233837912&repo=autoland&lineNumber=2481

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=c0c0b342f39e4edd365fd46e4961769f006e2493

Backout:
https://hg.mozilla.org/integration/autoland/rev/416032a984592cd291a7fc4a18253f929ef861ed

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d742819b35b
Missing bottom border on netmonitor table's header; r=ladybenko

Comment 8

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/2d742819b35b