Closed Bug 1531400 Opened 9 months ago Closed 8 months ago

Missing bottom border on netmonitor table's header

Categories

(DevTools :: Netmonitor, enhancement, P2)

enhancement

Tracking

(firefox67 fixed)

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: ochameau, Assigned: Honza)

References

Details

Attachments

(1 file, 1 obsolete file)

Because border doesn't work for <thead> and <tr>, we are missing the bottom border on the <thead> element of the netmonitor.
This bottom border comes from .devtools-toolbar rule.

I think that, unfortunately, we need dedicated CSS in order to address that.
We have to apply a bottom border to all the <td> elements.

Because <thead> and <tr> don't support border, we have to apply the style
to <td>.

Alex, just to note that I left a comment in phabricator.
https://phabricator.services.mozilla.com/D21556

Honza

Flags: needinfo?(poirot.alex)

Taking this bug as discussed with Alex.

Honza

Assignee: poirot.alex → odvarko
Status: NEW → ASSIGNED
Flags: needinfo?(poirot.alex)
Priority: -- → P2
Attachment #9047417 - Attachment is obsolete: true
Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c0c0b342f39e
Missing bottom border on netmonitor table's header; r=ladybenko
Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2d742819b35b
Missing bottom border on netmonitor table's header; r=ladybenko
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
Flags: needinfo?(odvarko)
You need to log in before you can comment on or make changes to this bug.