Closed Bug 1531494 Opened 9 months ago Closed 8 months ago

Remove all non-implemented RTC stats dictionaries and fields from the WebIDL and the IPC code

Categories

(Core :: WebRTC, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: ng, Assigned: ng)

References

Details

Attachments

(1 file)

There is bit rot in the unimplemented stats in RTCStatsReport.webidl and the WebrtcGlobals.h. The spec keeps moving, which promotes continuing rot. So if a field is not implemented (it is always undefined), a dictionary is never created, or an enum value is never used, it should be pruned. This will aid with review-ability, and will tie the expected output of getStats() to the WebIDL.

The stats dictionaries enjoy the luxury of never being used as parameters to any parts of the API, which makes this pruning easier.

This removes all the unimplemented RTCStats types from RTCStatsReport.webidl and deletes the related code

Spec review notes: the WebRTC-stats spec[0]

This removes a number of dictionaries we have never omitted and have drifted from the earlier drafts of the spec. It should be noted that these dictionary types are never consumed by the WebRTC API, they are merely informative stats reported by it. It is not expected that a consumer of the WebRTC API would ever create a dictionary of these types. As such, this should have zero compatibility impact.

It is expected that these dictionaries will be re-added as they are implemented.

[0] https://w3c.github.io/webrtc-stats/

Pushed by na-g@nostrum.com:
https://hg.mozilla.org/integration/autoland/rev/9eaf669d5fec
remove all unimplemented RTCStats types from the WebIDL and prune related dead code r=bwc,smaug
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
https://hg.mozilla.org/projects/ash/rev/9eaf669d5fec6b897bbce1a76899bd426130e778
Bug 1531494 - remove all unimplemented RTCStats types from the WebIDL and prune related dead code r=bwc,smaug
You need to log in before you can comment on or make changes to this bug.