1531623 - Identifier conflicts involving typedefs are inscrutable

Status: RESOLVED FIXED

(Core :: DOM: Bindings (WebIDL), enhancement)

Description

[Boris Zbarsky [:bzbarsky]]

If I try to parse this IDL:

  typedef long foo;
  typedef long foo;

I get an exception like so:

  AttributeError: 'IDLTypedef' object has no attribute 'innerType'

This is not helpful. It happens because IDLTypedef.__init__ tries to resolve the identifier conflict before assigning self.innerType, but when that fails it tries to call __str__ in the IDLTypedef, which tries to use self.innerType.

We should either assign .innerType first or change __str__ to deal. If I do the assignment first, then for my testcase I get:

  WebIDLError: error: Multiple unresolvable definitions of identifier 'foo' in scope '::
        Typedef foo Long at <unknown> line 2:4
    typedef long foo;
    ^
        Typedef foo Long at <unknown> line 3:4
    typedef long foo;
    ^

which is a lot nicer.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1531623. Fix webidl identifier conflicts involving typedefs to produce saner exceptions. r=qdot

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ab896c5a05d
Fix webidl identifier conflicts involving typedefs to produce saner exceptions.  r=qdot

Comment 3

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/5ab896c5a05d