1531655 - Emit a configure error if rustc version >= 1.33 and --enable-rust-simd used

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Henri Sivonen (:hsivonen)]

Mike Hommey [:glandium] wrote in bug 1521734 comment 15:

That said, before that, we should make --enable-rust-simd error out if building with rust >= 1.33, and uplift that to all branches, including esr, because wasting all this time to fail during the build is not going to help anybody.

Comment 1

[Henri Sivonen (:hsivonen)]

Attachment: Bug 1531655 - Emit a configure error if rustc version >= 1.33 and --enable-rust-simd used.

Comment 2

[Henri Sivonen (:hsivonen)]

Attachment: Bug 1531655 - Emit a configure error if rustc version >= 1.33 and --enable-rust-simd used.

(ESR backport of patch)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8d8af44ae92
Emit a configure error if rustc version >= 1.33 and --enable-rust-simd used. r=glandium

Comment 4

[Henri Sivonen (:hsivonen)]

And this breaks artifact build:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=231212034&repo=autoland&lineNumber=775

Comment 5

[Mike Hommey [:glandium]]

A reasonable thing to do is to change the check to if rustc_info and rustc_info.version... ; and file a followup to make this whole thing dependent on compile_environment, like e.g. --with-system-libvpx.

Comment 6

[Henri Sivonen (:hsivonen)]

Let's see if this try run ends up running artifact builds, too:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8e3a9d415a9c083a667a873e53c51fa7e205403a

Comment 7

[Natalia Csoregi [:nataliaCs]]

Backed out for artifact build bustage

backout: https://hg.mozilla.org/integration/autoland/rev/a1a345331f32ecb54392e116a3b7553f9de8f1d2

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=231210773&repo=autoland&lineNumber=858

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1ba7c69a2c9
Emit a configure error if rustc version >= 1.33 and --enable-rust-simd used. r=glandium

Comment 9

[Henri Sivonen (:hsivonen)]

(In reply to Mike Hommey [:glandium] from comment #5)

file a followup to make this whole thing dependent on compile_environment, like e.g. --with-system-libvpx.

Filed as bug 1531691.

Comment 10

[Henri Sivonen (:hsivonen)]

Comment on attachment 9047610 [details]
Bug 1531655 - Emit a configure error if rustc version >= 1.33 and --enable-rust-simd used.

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: None
• User impact if declined: People who build Firefox from source using Rust 1.33 without the fix for bug 1521249 will be confused. This person could be the end user in the case of packaging systems that build binaries on the end user's system.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a build system-only early error in a case where the build would fail anyway, and the patch does not fail on treeherder.
• String changes made/needed: None

Comment 11

[Henri Sivonen (:hsivonen)]

Comment on attachment 9047614 [details]
Bug 1531655 - Emit a configure error if rustc version >= 1.33 and --enable-rust-simd used.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Rust 1.33 removed compiler internals that the simd crate (enabled by --enable-rust-simd) depended on. Since the replacement, the packed_simd crate, does not build with the Rust version that Mozilla's build infra pins for ESR60, the fix for bug 1521249 can't land on ESR. However, downstream packagers who package ESR but roll Rust versions forward need to be pointed to bug 1521249 so that they can apply the ESR backport of packed_simd usage if they build with Rust 1.33 or higher and don't want to regress user-facing performance.
• User impact if declined: People who build Firefox from source using Rust 1.33 without the fix for bug 1521249 will be confused. This person could be the end user in the case of packaging systems that build binaries on the end user's system.
• Fix Landed on Version: 67
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a build system-only early error in a case where the build would fail anyway, and the patch does not fail on treeherder.
• String or UUID changes made by this patch: None

Comment 12

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/f1ba7c69a2c9

Comment 13

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9047610 [details]
Bug 1531655 - Emit a configure error if rustc version >= 1.33 and --enable-rust-simd used.

OK for uplift for beta 13.

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/561a9eb1b304

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9047610 [details]
Bug 1531655 - Emit a configure error if rustc version >= 1.33 and --enable-rust-simd used.

Doesn't affect the builds we ship, just makes builds fail earlier than they otherwise would have for users building with Rust 1.33. Approved for mozilla-release and esr60.

Comment 16

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-esr60/rev/6d17a75a4abc

Comment 17

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-release/rev/199e000595ec