1531716 - JS_ROUNDUP(x, y) evaluates y three times

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P5)

Description

[Jon Coppeard (:jonco)]

JS_ROUNDUP is defined like this:

#define JS_HOWMANY(x, y) (((x) + (y)-1) / (y))
#define JS_ROUNDUP(x, y) (JS_HOWMANY(x, y) * (y))

Hopefully this is never passed an expression with side effects!

This could be replaced by an inline function.

Comment 1

[André Bargull [:anba]]

Taking this bug to replace the jstypes macros and update some other macros.

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1531716 - Part 1: Remove macros for generating the SmallChars array. r=jonco!

And the two macros to convert to and from SmallChars.

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1531716 - Part 2: Remove unused macro in vm/Probes.cpp. r=jonco!

Depends on D51139

Comment 4

[André Bargull [:anba]]

Attachment: Bug 1531716 - Part 3: Replace ROUNDUP with JS_ROUNDUP. r=jonco!

Both macros compute the same result, so we can replace ROUNDUP with JS_ROUNDUP.

Depends on D51140

Comment 5

[André Bargull [:anba]]

Attachment: Bug 1531716 - Part 4: Replace jstypes macros with constexpr functions. r=jonco!

JS_BIT and JS_BITMASK are only used in contexts where uint32_t is used, so these
two functions are now typed to accept and return uint32_t.

JS_HOWMANY and the three JS_ROUND functions are only used with size_t inputs,
so these four functions are now typed to accept and return size_t.

Depends on D51141

Comment 6

[Cosmin Sabou [:CosminS]]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. applying /tmp/tmpyyKH7w js/src/vm/TypedArrayObject.cpp Hunk #4 FAILED at 234. 1 out of 5 hunks FAILED -- saving rejects to file js/src/vm/TypedArrayObject.cpp.rej abort: patch command failed: exited with status 256

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e0afb29911a
Part 1: Remove macros for generating the SmallChars array. r=jonco
https://hg.mozilla.org/integration/autoland/rev/865b84a23e9e
Part 2: Remove unused macro in vm/Probes.cpp. r=jonco
https://hg.mozilla.org/integration/autoland/rev/93e5393aa92b
Part 3: Replace ROUNDUP with JS_ROUNDUP. r=jonco
https://hg.mozilla.org/integration/autoland/rev/3a9b6b73cab7
Part 4: Replace jstypes macros with constexpr functions. r=jonco

Comment 8

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/0e0afb29911a
https://hg.mozilla.org/mozilla-central/rev/865b84a23e9e
https://hg.mozilla.org/mozilla-central/rev/93e5393aa92b
https://hg.mozilla.org/mozilla-central/rev/3a9b6b73cab7