1531768 - The state of "Remember this decision" checkbox is not visible on doorhangers

Status: VERIFIED FIXED

(Firefox :: Site Identity, defect, P1)

Description

[Gyula Palko[:gpalko]]

Affected versions

• Nightly 67.0a1

Affected platforms

• Windows, MacOS, Ubuntu

Steps to reproduce

1. Launch Firefox Nightly
2. Open https://mozilla.github.io/webrtc-landing/gum_test.html
3. Click the Audio&Video button
4. Click Allow on the camera and microphone access doorhanger
5. Reload the page and select Audio&Video button again
6. Click on the "Remember this decision" checkbox

Expected result

• Checked/Unchecked state is visible on the checkbox

Actual result

• The checkbox is empty after every click, the user doesn't know if the checkbox is checked or not

Regression range:
After running mozregression, it seems that this was introduced by https://bugzilla.mozilla.org/show_bug.cgi?id=1487065:

Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=de71a4462179bb6c014c5e11782aad68db7648e0&tochange=04b57ffa53ce4c248bc3869247fed266b37eab2f

Notes
This is reproducible on all doorhangers, except the Location access doorhanger.

Comment 1

[Johann Hofmann [:johannh]]

Brian, can you take a look, please? Thank you!

Comment 2

[Johann Hofmann [:johannh]]

[Tracking Requested - why for this release]:

Can't use checkbox in permission doorhangers.

Comment 3

[SresthaSrivastava [:srestha]]

@johannh can I take this up?

Comment 4

[Johann Hofmann [:johannh]]

I'm not sure what caused this so I think Brian should take a look at it first.

Comment 5

[Brian Grinstead [:bgrins]]

I can't reproduce it locally, but I think it might be something wrong on my end. After step 4 (Click Allow on the camera and microphone access doorhanger), it doesn't actually share my camera and I see "NotFoundError: The object can not be found here." in the console and displayed in red in the page. I was seeing this error when running some of the webrtc mochitests as well (which were failing locally both before and after Bug 1487065, but passing on try in both cases).

Comment 6

[SresthaSrivastava [:srestha]]

Okay, please assign me some other bug till then. Also, how do I self assign a bug?

Comment 7

[Brian Grinstead [:bgrins]]

Matt and I walked through some pretty complicated logic for maintaining the checkbox state within popupnotification using checkboxState and _onCheckboxCommand when working on that bug. We ultimately ended up pulling the checkboxchecked attribute off of the popupnotification node (which was then being inherited down onto the checkbox) and managed more directly (https://searchfox.org/mozilla-central/rev/00f3836a87b844b5e4bc82f698c559b9966e4be2/toolkit/content/widgets/popupnotification.js#44) because I was seeing issues like the one filed here when we were using the attribute. Unfortunately I'm not seeing that discussion in https://phabricator.services.mozilla.com/D17699 so I think it happened on IRC.

My best guess is that this.checkboxState is getting reset to false after being set to true in _onCheckboxCommand (https://searchfox.org/mozilla-central/rev/00f3836a87b844b5e4bc82f698c559b9966e4be2/toolkit/modules/PopupNotifications.jsm#1459).

Matt or Johann, can you confirm the STR? As I mentioned in Comment 5 I'm not able to reproduce locally so it's hard for me to debug this.

Comment 8

[Brian Grinstead [:bgrins]]

Also, sorry, but I'm going to be offline next week so I won't have time to fix this before the merge. Matt, would you be able to take this over or find another owner for it?

Comment 9

[Matthew N. [:MattN]]

Yeah, I'll look into it next week.

Comment 10

[Matthew N. [:MattN]]

I can't reproduce this so I will do a mozregression to confirm the fix.

Comment 11

[Matthew N. [:MattN]]

Mozregression tells me this was fixed by https://hg.mozilla.org/integration/autoland/rev/623c6ca6ed6c (bug 1455433).

Gyula Palko, can you verify the fix?

Comment 12

[Gyula Palko[:gpalko]]

Verified, that the issue is no longer reproducible on the latest Nightly 67(20190305214137).