Closed Bug 1531825 Opened 7 years ago Closed 6 years ago

RTCDTMFSender.insertDTMF while tones are already playing begins playing the new tones immediately

Categories

(Core :: WebRTC: Signaling, enhancement, P3)

Product:
Core
Component:
WebRTC: Signaling
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: bwc, Assigned: bwc)

Details

Attachments

(2 files)

Bug 1531825 - Part 0: Re-enable some test-cases. r?jib
47 bytes, text/x-phabricator-request
Details | Review
Bug 1531825 - Part 1: Prevent already-set DTMF timers from being re-scheduled when new tones are set. Also some simplification. r?mjf
47 bytes, text/x-phabricator-request
Details | Review

Spec says that calling insertDTMF while previously set tones are playing does not immediately play the new tones, but should instead wait until the next tone (that insertDTMF just overrode) would have played.

Rank: 25
Priority: -- → P3
Summary: RTCDataChannel.insertDTMF while tones are already playing begins playing the new tones immediately → RTCDTMFSender.insertDTMF while tones are already playing begins playing the new tones immediately
Assignee: nobody → docfaraday
Pushed by bcampen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/02e5d6570623 Part 0: Re-enable some test-cases. r=jib https://hg.mozilla.org/integration/autoland/rev/0c7d2a3b78a0 Part 1: Prevent already-set DTMF timers from being re-scheduled when new tones are set. Also some simplification. r=mjf

https://hg.mozilla.org/mozilla-central/rev/02e5d6570623
https://hg.mozilla.org/mozilla-central/rev/0c7d2a3b78a0

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: