1531828 - RTCDTMFSender ontonechange events should stop if the transceiver stops sending

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, enhancement, P3)

Description

[Byron Campen [:bwc]]

We seem to prevent the actual transmission of tones of course, but we're also supposed to stop firing the events and scheduling the timers.

Comment 1

[Byron Campen [:bwc]]

Attachment: Bug 1531828 - Part 0: Fix and re-enable a test-case. r?jib

Comment 2

[Byron Campen [:bwc]]

Attachment: Bug 1531828 - Part 1: Check that transceiver is sending before doing tone stuff. r?mjf

Depends on D28402

Comment 3

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f009e4bb41935a3589100c0eb14c7644f0104053

Comment 4

[Byron Campen [:bwc]]

Try looks good.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4d705b02c8e
Part 0: Fix and re-enable a test-case. r=jib
https://hg.mozilla.org/integration/autoland/rev/8f1305cd6725
Part 1: Check that transceiver is sending before doing tone stuff. r=mjf

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/c4d705b02c8e
https://hg.mozilla.org/mozilla-central/rev/8f1305cd6725

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/16710 for changes under testing/web-platform/tests

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged