Each new xul window does a stat call to look for non-existant window specific icons

RESOLVED FIXED in Firefox 67

Status

()

enhancement
RESOLVED FIXED
3 months ago
13 hours ago

People

(Reporter: florian, Assigned: florian)

Tracking

({perf})

unspecified
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

(Whiteboard: [fxperf:p1])

Attachments

(2 attachments)

Assignee

Description

3 months ago

I'm looking a startup main thread I/O, and during early startup we stat browser\chrome\icons\default\default.ico when doing the starting the layout in toolkit/content/gfxsanity/sanityparent.html and then a second time when doing it in omni.ja!/chrome/toolkit/res/hiddenWindow.html

Later we stat browser\chrome\icons\default\main-window.ico when opening the browser window.

None of these files exist. Firefox doesn't provide window-specific icon files, and uses the application icon for all windows.

Thunderbird uses that feature though, so I suggest that we reverse the behavior: instead of looking for an icon file on disk by default, we should only do it if an "icon" attribute has been specified.

Comment 3

3 months ago

Pushed by fqueze@mozilla.com:
https://hg.mozilla.org/comm-central/rev/0ec9e8d998fc
adjust Thunderbird code to use the 'icon' attribute to set the icon of XUL windows, r=mkmelin.

Status: NEW → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED

Comment 4

3 months ago
Pushed by fqueze@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d8cdae952942
only look for a window specific icon on the disk if an 'icon' attribute has been specified on the XUL window, r=NeilDeakin.
Assignee

Updated

3 months ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 5

3 months ago
bugherder
Status: REOPENED → RESOLVED
Last Resolved: 3 months ago3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

Comment 6

13 hours ago

What is the solution for people who were using main-window.ico to set a custom taskbar icon? That ability was of particular value where one wished to run multiple instances of Firefox, each with its own profile, and be able to easily distinguish between them by giving each a distinct taskbar icon. Since Firefox doesn't provide a way to do it via profiles alone, it was achieved with multiple installs, each with their own main-window.ico (inelegant, but at least it worked).

You need to log in before you can comment on or make changes to this bug.