1531863 - Implement the `show-poster-flag` for HTMLMediaElement

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P2)

Description

[Alastor Wu [:alwu]]

https://html.spec.whatwg.org/multipage/media.html#show-poster-flag

There are some places in the spec which mention we should run timeMarchesOn algorithm if the show-poster-flag is true, but we didn't implement this flag for HTMLMediaElement.

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1531863 - part1 : implement 'GetMediaElement()' function wrapper.

To create a function wrapper which would automatically check whether track list exists, in order to reduce unnecessary checking.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1531863 - part2 : handle text track mode changed in MediaElement.

In order to make the implementation more fitting with the spec, move the implementation of pending-text-track-change-notification-flag fomr text track list to media element.

In addition, it also help us not to expose the internal flag show-poster (which will be implemented in patch3) of media element when doing the related algorithm.

Comment 3

[Alastor Wu [:alwu]]

Attachment: Bug 1531863 - part3 : implement the 'show-poster-flag' for HTMLMediaElement.

According to the spec [1], implement the show-poster-flag which is used to decide whether we need to run TimeMarchesOn algorithm under certain situations.

[1] https://html.spec.whatwg.org/multipage/media.html#show-poster-flag

Comment 4

[Alastor Wu [:alwu]]

Attachment: Bug 1531863 - part4 : enable wpt 'track-change-event.html'.

Add missing augment and enable the wpt.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9628b2b89b2
part1 : implement 'GetMediaElement()' function wrapper. r=jya
https://hg.mozilla.org/integration/autoland/rev/21bafd01b438
part2 : handle text track mode changed in MediaElement. r=jya
https://hg.mozilla.org/integration/autoland/rev/5be609c16665
part3 : implement the 'show-poster-flag' for HTMLMediaElement. r=jya
https://hg.mozilla.org/integration/autoland/rev/e2e2b325344f
part4 : enable wpt 'track-change-event.html'. r=jya

Comment 6

[Cristian Brindusan [:cbrindusan]]

Backed out 4 changesets (Bug 1531863) for mochitest failures at test_videocontrols_vtt.html.

Backout: https://hg.mozilla.org/integration/autoland/rev/b653c9d4de17e17b4f7273ed192d10414222f88b

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&selectedJob=232543553&revision=e2e2b325344fcda75fe015b3de5ba25bd53613ba

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=232543553&repo=autoland&lineNumber=40830

Comment 7

[Alastor Wu [:alwu]]

Attachment: Bug 1531863 - part5 : modify test 'test_videocontrols_vtt.html'.

According to the spec [1] step3, the 'change' event won't be dispatched immediately, so we should run the following check until we get the 'change' event.

[1] https://html.spec.whatwg.org/multipage/media.html#pending-text-track-change-notification-flag

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b9bb0da7cd6
part1 : implement 'GetMediaElement()' function wrapper. r=jya
https://hg.mozilla.org/integration/autoland/rev/6dbda553b478
part2 : handle text track mode changed in MediaElement. r=jya
https://hg.mozilla.org/integration/autoland/rev/442e99192e46
part3 : implement the 'show-poster-flag' for HTMLMediaElement. r=jya
https://hg.mozilla.org/integration/autoland/rev/859e7f4b9cb1
part4 : enable wpt 'track-change-event.html'. r=jya
https://hg.mozilla.org/integration/autoland/rev/7ae9bc24596f
part5 : modify test 'test_videocontrols_vtt.html'. r=jaws

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/5b9bb0da7cd6
https://hg.mozilla.org/mozilla-central/rev/6dbda553b478
https://hg.mozilla.org/mozilla-central/rev/442e99192e46
https://hg.mozilla.org/mozilla-central/rev/859e7f4b9cb1
https://hg.mozilla.org/mozilla-central/rev/7ae9bc24596f

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/15784 for changes under testing/web-platform/tests

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging