1531885 - RTCPeerConnection constructor exceptions related to RTCCertificate aren't surfaced properly

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, enhancement, P3)

Description

[Byron Campen [:bwc]]

We do throw exceptions like this:

https://searchfox.org/mozilla-central/rev/00f3836a87b844b5e4bc82f698c559b9966e4be2/dom/media/PeerConnection.jsm#478

But, they aren't surfaced correctly, because this happens in an async function. The promise is stored, but the RTCPeerConnection constructor does not throw when this happens:

https://searchfox.org/mozilla-central/rev/00f3836a87b844b5e4bc82f698c559b9966e4be2/dom/media/PeerConnection.jsm#450

Comment 1

[Byron Campen [:bwc]]

Attachment: Bug 1531885: Surface certificate-related errors in RTCPeerConnection's c'tor, fix an error type, and re-enable a test. r?jib

Comment 2

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e1f917d08b4c76418eeb76042997089e15619fb4

Comment 3

[Byron Campen [:bwc]]

Try looks good.

Comment 4

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e77e0dc134e823397c9cf294143215f7cecb4f57

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28fa2a88940e
Surface certificate-related errors in RTCPeerConnection's c'tor, fix an error type, and re-enable a test. r=jib

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/28fa2a88940e