Closed Bug 1531908 Opened 9 months ago Closed 7 months ago

RTCPeerConnection.createDataChannel does not check the length of the label

Categories

(Core :: WebRTC: Signaling, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: bwc, Assigned: bwc)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(1 file, 1 obsolete file)

Spec says we need to throw TypeError if the label is longer than 65535 bytes.

Rank: 35
Priority: -- → P4
Blocks: 1533020
Keywords: good-first-bug
Priority: P4 → P3

Depends on D28557

Assignee: nobody → docfaraday

This probably needs a rebase.

Attachment #9060225 - Attachment is obsolete: true

Try looks good.

Pushed by bcampen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/28b74f2993a1
Part 0: Re-enable a test-case, and check length of label based on UTF-8 encoding. r=jib
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.