1531908 - RTCPeerConnection.createDataChannel does not check the length of the label

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, enhancement, P3)

Description

[Byron Campen [:bwc]]

Spec says we need to throw TypeError if the label is longer than 65535 bytes.

Comment 1

[Byron Campen [:bwc]]

Attachment: Bug 1531908 - Part 0: Re-enable a test-case, and check length of label based on UTF-8 encoding. r?jib

Depends on D28556

Comment 2

[Byron Campen [:bwc]]

Attachment: Bug 1531908 - Part 1: Fix a couple of broken test-cases. r?jib

Depends on D28557

Comment 3

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=aa6521ff0f0a11acebcf36c8765d0218b48b08ff

Comment 4

[Byron Campen [:bwc]]

This probably needs a rebase.

Comment 5

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=affbf656109d84fea58410c9025dc91107753392

Comment 6

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=527380794c23a02f9097caffa9b58bdef09a3e37

Comment 7

[Byron Campen [:bwc]]

Try looks good.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28b74f2993a1
Part 0: Re-enable a test-case, and check length of label based on UTF-8 encoding. r=jib

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/28b74f2993a1