Closed Bug 1531910 Opened 7 months ago Closed 5 months ago

RTCPeerConnection.createDataChannel does not check the length of the protocol

Categories

(Core :: WebRTC: Signaling, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: bwc, Assigned: bwc)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This also should be no longer than 65535 bytes.

Rank: 35
Priority: -- → P4
Blocks: 1533020
Priority: P4 → P3
Assignee: nobody → docfaraday

Looks like we have some new tests that were failing because of this. Need to mark those as expected to pass.

Pushed by bcampen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/beae0db3529d
Re-enable a test-case, and check protocol length based on UTF-8 encoding. r=jib
Pushed by bcampen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/01bb0bd5e987
Re-enable a test-case, and check protocol length based on UTF-8 encoding. r=jib
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Flags: needinfo?(docfaraday)
You need to log in before you can comment on or make changes to this bug.