1531910 - RTCPeerConnection.createDataChannel does not check the length of the protocol

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P3)

Description

[Byron Campen [:bwc]]

This also should be no longer than 65535 bytes.

Comment 1

[Byron Campen [:bwc]]

Attachment: Bug 1531910: Re-enable a test-case, and check protocol length based on UTF-8 encoding. r?jib

Depends on D28252

Comment 2

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=60d4594af37095eeb2eac12a346be71a7a6ab373

Comment 3

[Byron Campen [:bwc]]

Looks like we have some new tests that were failing because of this. Need to mark those as expected to pass.

Comment 4

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3494ab53293527a8b8e4fd3ea51b1aa2f4290e22

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/beae0db3529d
Re-enable a test-case, and check protocol length based on UTF-8 encoding. r=jib

Comment 6

[Dorel Luca [:dluca]]

Backed out changeset beae0db3529d (bug 1531910) for WPT failures in webrtc/RTCPeerConnection-createDataChannel.html

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=244493353&repo=autoland&lineNumber=103190

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=beae0db3529d6490795e69d6d6567fb74b95ffe8

Backout:
https://hg.mozilla.org/integration/autoland/rev/376d2f3bd8d97d0dd6a10566503fcc83f75dcdea

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01bb0bd5e987
Re-enable a test-case, and check protocol length based on UTF-8 encoding. r=jib

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/01bb0bd5e987