Retriggers do not pick up --env settings
Categories
(Firefox Build System :: Task Configuration, task)
Tracking
(Not tracked)
People
(Reporter: sfink, Unassigned)
Details
I did a push with mach try fuzzy --env MOZ_DISABLE_CONTENT_SANDBOX=1 and selected my job. I retriggered it a bunch of times, but the environment variable setting was gone for those runs. You can clearly see the effect at https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=230631762&revision=1e3d80ca1fbe8d018e39d6d71fd9dad7706494d3
I would like environment variable settings to be preserved for retriggers.
|
||
Comment 1•6 years ago
|
||
I think this occurs because the env var is added to the task as a morph, which occurs after the full task graph is written out. Retriggering just uses that full task graph to generate a new copy of the task, but doesn't know that it was subsequently morphed.
Andrew, I feel like there are other bugs like this -- perhaps a dupe?
|
||
Comment 2•6 years ago
|
||
We should definitely move the handling of these kinds of try options in the transforms, rather than as morphs.
|
||
Comment 3•6 years ago
|
||
Yeah, there's some discussion in the other bug around this, let's move over there.
Description
•