Remove Option<>s from TransformOperation.
Categories
(Core :: CSS Parsing and Computation, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(5 files)
They're not usable via FFI, and they should not be needed. This patches also change the serialization of transform operations to follow the same principle we use for single transform properties.
I think that slight change is fine, if we can make it work, and consistent with other properties. Alternative is adding more TransformOperation variants, which I rather not do.
|
Assignee | |
Comment 1•5 years ago
|
||
I called it contextual_skip_if, though better names welcome.
|
|
Assignee | |
Comment 2•5 years ago
|
||
Otherwise, deriving ToComputedValue and ToAnimatedValue in structs or enums with
other where clauses just doesn't work.
Depends on D21858
|
|
Assignee | |
Comment 3•5 years ago
|
||
Trivial drive-by cleanup.
Depends on D21859
|
|
Assignee | |
Comment 4•5 years ago
|
||
Also drive-by cleanup.
Depends on D21860
|
|
Assignee | |
Comment 5•5 years ago
|
||
This may or may not be part of the plan to get rid of nsCSSValue ;)
Option is not usable via FFI, and they should not be needed (we should be
following the shortest serialization principle instead). These patches also do
that, which matches the other transform properties. I think that slight change
is fine, if we can make it work, and consistent with other properties.
Alternative is adding more TransformOperation variants or such, which I rather
not do.
Depends on D21861
|
|
Assignee | |
Updated•5 years ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b5dec9e96f42 Implement a version of #[css(skip_if)] that takes more context. r=xidorn https://hg.mozilla.org/integration/autoland/rev/7aa72a6aa1b5 When deriving something with an output type, map preconditions as well. r=xidorn https://hg.mozilla.org/integration/autoland/rev/5a4a2f2465b0 Use skip_if for translate serialization. r=xidorn https://hg.mozilla.org/integration/autoland/rev/2b811ffbed9b Use contextual_skip_if for background-size. r=xidorn https://hg.mozilla.org/integration/autoland/rev/950681627741 Remove Options from TransformOperation. r=xidorn
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b5dec9e96f42
https://hg.mozilla.org/mozilla-central/rev/7aa72a6aa1b5
https://hg.mozilla.org/mozilla-central/rev/5a4a2f2465b0
https://hg.mozilla.org/mozilla-central/rev/2b811ffbed9b
https://hg.mozilla.org/mozilla-central/rev/950681627741
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/15715 for changes under testing/web-platform/tests
Upstream PR merged
Description
•