Closed Bug 1532194 Opened 1 year ago Closed 1 year ago

Remove or fix -DDEBUG_$USER from make builds

Categories

(NSS :: Build, enhancement, P2)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mt, Assigned: louis.dassy)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

The NSS build helpfully defines a macro based on the user ID from the system. Where $USER includes a period (.), the resulting invocation of the compiler is invalid, as only certain characters are valid.

The error message is very helpful, of course:

$ echo 'int main() {}' | cc -DDEBUG_test.dot -o tmp -x c -
<command-line>: warning: ISO C99 requires whitespace after the macro name

This either needs to be fixed, by scrubbing the macro for odd characters and replacing them (with _ for example), or removed altogether. This isn't used that often, and we don't have any remaining instances in the tree, so my preference is to remove the capability. The gyp-based builds don't include the feature already.

Priority: -- → P2
Assignee: nobody → louis.dassy
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 3.46
You need to log in before you can comment on or make changes to this bug.