1532194 - Remove or fix -DDEBUG_$USER from make builds

Status: RESOLVED FIXED

(NSS :: Build, enhancement, P2)

Description

[Martin Thomson [:mt:]]

The NSS build helpfully defines a macro based on the user ID from the system. Where $USER includes a period (.), the resulting invocation of the compiler is invalid, as only certain characters are valid.

The error message is very helpful, of course:

$ echo 'int main() {}' | cc -DDEBUG_test.dot -o tmp -x c -
<command-line>: warning: ISO C99 requires whitespace after the macro name

This either needs to be fixed, by scrubbing the macro for odd characters and replacing them (with _ for example), or removed altogether. This isn't used that often, and we don't have any remaining instances in the tree, so my preference is to remove the capability. The gyp-based builds don't include the feature already.

Comment 1

[Louis Dassy]

Attachment: Bug 1532194 - Remove -DDEBUG_$USER from make builds

Comment 2

[Martin Thomson [:mt:]]

https://hg.mozilla.org/projects/nss/rev/8c6fad5544a6