Closed Bug 1532199 Opened 1 year ago Closed 1 year ago

Don't flush pending styles when taking a thumbnail for sites

Categories

(Core :: Widget: Android, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: hiro, Assigned: hiro)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Given that it's possible that other style changes often happen after the style flush, it doesn't much matter if the thumbnail is for a bit stale appearance. Avoiding the flush might improve responsiveness to some extent since the flush is actually an unexpected flush from the perspective of site authors.

Moreover flushing the style on taking the thumbnail can't be controllable in automation tests at all, it's actually a source of intermittent failures, bug 1522825 is one of them (I don't know others but I suspect there are others).

https://treeherder.mozilla.org/#/jobs?repo=try&revision=afe5261a04e5d278d775abe5c37f7c16121dc693

Pushed by hikezoe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/79cc37f5c16d
Don't flush pending styles when taking a snapshot for thumnail. r=snorp
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.