1532199 - Don't flush pending styles when taking a thumbnail for sites

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

Given that it's possible that other style changes often happen after the style flush, it doesn't much matter if the thumbnail is for a bit stale appearance. Avoiding the flush might improve responsiveness to some extent since the flush is actually an unexpected flush from the perspective of site authors.

Moreover flushing the style on taking the thumbnail can't be controllable in automation tests at all, it's actually a source of intermittent failures, bug 1522825 is one of them (I don't know others but I suspect there are others).

https://treeherder.mozilla.org/#/jobs?repo=try&revision=afe5261a04e5d278d775abe5c37f7c16121dc693

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1532199 - Don't flush pending styles when taking a snapshot for thumnail. r=snorp

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79cc37f5c16d
Don't flush pending styles when taking a snapshot for thumnail. r=snorp

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/79cc37f5c16d