1532238 - Autocomplete does not work in browser console

Status: RESOLVED FIXED

(DevTools :: Console, defect, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

When typing in the browser console input, there's the following error:

error occurred while processing 'autocomplete: TypeError: debugger and debuggee must be in different compartments
Stack: autocomplete@resource://devtools/server/actors/webconsole.js:1185:30
onPacket@resource://devtools/server/main.js:1291:58
send/<@resource://devtools/shared/transport/local-transport.js:64:23
exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:109:22
exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:109:22
Line: 1185, column: 30 main.js:1160
    _unknownError resource://devtools/server/main.js:1160
    onPacket resource://devtools/server/main.js:1294
    send resource://devtools/shared/transport/local-transport.js:64
    makeInfallible resource://devtools/shared/ThreadSafeDevToolsUtils.js:109
    makeInfallible resource://devtools/shared/ThreadSafeDevToolsUtils.js:109

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

This is the offender devtools/server/actors/webconsole.js#1185 (basically, when we try to add a debuggee)

Comment 2

[Alexandre Poirot [:ochameau]]

This is related to bug 1515290.

Now that we share a unique compartment between all chrome contexts (devtools sandboxes, jsm, chrome documents, js xpcom, ...),
we now have to flag the loader with invisibleToDebugger=true when we are debugging a chrome context (one of which I listed here).
This is only for the server. This is only to ensure that the actors, which use the Debugger API are loaded in a distinct compartment. invisibleToDebugger ends up forcing loading all the modules in a special, distinct compartment. This compartment story is specific to Debugger API, the debugger has to know the boundaries of its debuggee and it uses compartments boundaries to know if a given frame is part of the debuggee or the debugger implementation.

So, for the browser console, we are debugging such chrome context. We have to ensure that the DebuggerServer used by the browser console is loaded by a Loader with invisibleToDebugger=true. I most likely missed that when working on bug 1515290.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1532238 - Run Browser console's server in a dedicated compartment.

Bug 1517210 ensured that the debugger server was running in the shared system compartment.
The same one for JSMs, JS-XPCOM and DevTools Sandboxes. But that doesn't work when
the server has to debug system Javascripts. In such case, we have to ensure loading
the server in a special loader flagged with invisibleToDebugger=true. This forces
loading the server in another compartment and helps the debugger indentify the boundaries
between debugee and debugger code.

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1532238 - Add test.

Depends on D22062

Comment 5

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a6cfca8f4eccdc322d4a3d37e842ff92dcf64a6

Comment 6

[Alexandre Poirot [:ochameau]]

I'm having a hard time having a green test on try for this, so I'll move the test to followup bug 1532653.

Here is a new try:
https://treeherder.mozilla.org/#/jobs?repo=try&searchStr=dt4&revision=c76e5b0e426c6f2cb5705044a3ff0606d9647aba

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fccf1be20f4b
Run Browser console's server in a dedicated compartment. r=nchevobbe

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/fccf1be20f4b