1532295 - Webconsole's onViewSourceInDebugger doesn't pass column number to debugger panel when opening a source

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P2)

Description

[Alexandre Poirot [:ochameau]]

The code over here:
https://searchfox.org/mozilla-central/rev/92d11a33250a8e368c8ca3e962e15ca67117f765/devtools/client/shared/components/reps/reps.js#6844-6848

        props.onViewSourceInDebugger({
          url: filename,
          line: lineNumber,
          column: columnNumber
        });

Pass a column attribute, but that isn't implemented in onViewSourceInDebugger:
https://searchfox.org/mozilla-central/rev/92d11a33250a8e368c8ca3e962e15ca67117f765/devtools/client/webconsole/webconsole-wrapper.js#261-270

          onViewSourceInDebugger: frame => {
            this.toolbox.viewSourceInDebugger(
              frame.url, frame.line, frame.sourceId
            ).then(() => {
              this.telemetry.recordEvent(
                "jump_to_source", "webconsole",
                null, { "session_id": this.toolbox.sessionId }
              );
              this.webConsoleUI.emit("source-in-debugger-opened");
            });

I'll make this bug depend on bug 1531826 as it is already in process of modifying toolbox's viewSourceInDebugger function.

Comment 1

[Mellina Y.]

Hi everyone,
Not sure if this is already being done, but I'm available to be assigned this issue :)

Thanks

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Hello Mellina, thanks for offering help!
I'm assigning the bug to you.

If you don't have setup the work environment yet, you can have a look at http://docs.firefox-dev.tools/getting-started/ . Make sure to choose "Artifact builds" when asked to, as it's much faster to work with those.

Don't hesitate to ask any question you might have, here or on Slack :)

Comment 3

[Mellina Y.]

Hi Nicolas,

Thanks :) I'll start working on it today and will have updates later.

Comment 4

[Mellina Y.]

Attachment: Bug 1532295 - Webconsole's onViewSourceInDebugger doesn't pass column number to debugger panel when opening a source. r=nchevobbe.

Pass on column from props.onViewSourceInDebugger (///devtools/client/shared/components/reps/reps.js:6844//) to
//devtools/client/webconsole/webconsole-wrapper.js:267// as frame.column

Comment 5

[Mellina Y.]

Hi everyone,

I don't know who is reviewing, so I have tagged the reporter and Nicolas.

I tried testing (mochitest and console.log) and none worked, so I'm not sure if that was successful. Please let me know if that was not what was requested.

Thanks!

Comment 6

[Mellina Y.]

Attachment: Bug 1532295 - Change mochitest in head.js and revert changes on browser_webconsole_location_debugger_link.js

Comment 7

[Mellina Y.]

Attachment: Bug 1532295 - Solve rebasing conflicts

Depends on D23364

Comment 8

[Mellina Y.]

Hi Nicolas,
I have sent a review, but in different Phabricator links :/ sorry about that.

Comment 9

[Nicolas Chevobbe [:nchevobbe]]

(clearing needinfo)

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/312a73dcfb90
Webconsole's onViewSourceInDebugger doesn't pass column number to debugger panel when opening a source. .

Comment 11

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/312a73dcfb90