1532303 - Resolve failure of WPT /service-workers/service-worker/Service-Worker-Allowed-header.https.html

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect, P2)

Description

[Yaron Tausky [:ytausky]]

Two test cases in this suite fail, both involve a Service-Worker-Allowed header whose origin is different than the page's. As far as I can tell from the Update algorithm's step 9, substeps 8-18, only the URL's path is involved in determining whether a given scope can be controlled by the service worker, so Gecko indeed handles this case wrong.

Comment 1

[Yaron Tausky [:ytausky]]

Attachment: Bug 1532303: Fix evaluation of Service-Worker-Allowed header

The spec mandates that only the paths of the URIs resulting from evaluation
of the Service-Worker-Allowed header and the registration's scope be compared,
yet Gecko also includes the origin in the comparison. This commit makes Gecko
follow the spec.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/51a634029b44
Fix evaluation of Service-Worker-Allowed header r=perry,asuth

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/51a634029b44

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

Spec behavior is likely changing in https://github.com/w3c/ServiceWorker/issues/1307 under PR https://github.com/w3c/ServiceWorker/pull/1409 to conform to our pre-patch behavior.

Yaron, do you think we should revert the (non-meta parts of the) patch, or refine the post-patch logic?

Comment 5

[Yaron Tausky [:ytausky]]

We could probably just revert it. It wasn't a complicated change.