1532328 - Perma browser/base/content/test/tabs/browser_tabCloseProbes.js | Uncaught exception - at chrome://mochitests/content/browser/browser/base/content/test/tabs/browser_tabCloseProbes.js:19 when version increases to Gecko 68 on 2019-03-18

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P5)

Description

[Treeherder Bug Filer]

#[markdown(off)]
Filed by: dluca [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=231630032&repo=try

https://queue.taskcluster.net/v1/task/eqHfrD9jR9ixc50bMUUOWg/runs/0/artifacts/public/logs/live_backing.log

TEST-START | browser/base/content/test/tabs/browser_tabCloseProbes.js
14:17:50 INFO - TEST-INFO | started process screencapture
14:17:50 INFO - TEST-INFO | screencapture: exit 0
14:17:50 INFO - Buffered messages logged at 06:17:49
14:17:50 INFO - Entering test bound setup
14:17:50 INFO - Leaving test bound setup
14:17:50 INFO - Entering test bound test_close_time_anim_probe
14:17:50 INFO - Buffered messages finished
14:17:50 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/tabs/browser_tabCloseProbes.js | Uncaught exception - at chrome://mochitests/content/browser/browser/base/content/test/tabs/browser_tabCloseProbes.js:19 - TypeError: snapshot is undefined
14:17:50 INFO - Stack trace:
14:17:50 INFO - snapshotCount@chrome://mochitests/content/browser/browser/base/content/test/tabs/browser_tabCloseProbes.js:19:3
14:17:50 INFO - assertCount@chrome://mochitests/content/browser/browser/base/content/test/tabs/browser_tabCloseProbes.js:35:16
14:17:50 INFO - test_close_time_anim_probe@chrome://mochitests/content/browser/browser/base/content/test/tabs/browser_tabCloseProbes.js:80:3
14:17:50 INFO - Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1106:34
14:17:50 INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1134:12
14:17:50 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:995:14
14:17:50 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:803:59
14:17:50 INFO - Leaving test bound test_close_time_anim_probe
14:17:50 INFO - Entering test bound test_close_time_no_anim_probe
14:17:50 INFO - Not taking screenshot here: see the one that was previously logged
14:17:50 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/tabs/browser_tabCloseProbes.js | Uncaught exception - Collected value should become 1. - threw exception: TypeError: snapshot is undefined
14:17:50 INFO - Leaving test bound test_close_time_no_anim_probe
14:17:50 INFO - GECKO(942) | MEMORY STAT | vsize 4553MB | residentFast 441MB | heapAllocated 148MB
14:17:50 INFO - TEST-OK | browser/base/content/test/tabs/browser_tabCloseProbes.js | took 1166ms
14:17:50 INFO - checking window state
14:17:50 INFO - TEST-START | browser/base/content/test/tabs/browser_tabContextMenu_keyboard.js
14:17:51 INFO - GECKO(942) | MEMORY STAT | vsize 4551MB | residentFast 441MB | heapAllocated 148MB
14:17:51 INFO - TEST-OK | browser/base/content/test/tabs/browser_tabContextMenu_keyboard.js | took 389ms
14:17:51 INFO - checking window state
14:17:51 INFO - TEST-START | browser/base/content/test/tabs/browser_tabReorder.js
14:17:51 INFO - GECKO(942) | MEMORY STAT | vsize 4557MB | residentFast 447MB | heapAllocated 165MB
14:17:51 INFO - TEST-OK | browser/base/content/test/tabs/browser_tabReorder.js | took 488ms

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

OS X and Windows debug builds assert:

Assertion failure: !IsExpired(), at /builds/worker/workspace/build/src/toolkit/components/telemetry/core/TelemetryHistogram.cpp:1034

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Mike, same procedure as in bug 1488952? Thank you in advance.

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

(In reply to Sebastian Hengst [:aryx] (needinfo on intermittent or backout) from comment #2)

Mike, same procedure as in bug 1488952? Thank you in advance.

Comment 4

[Intermittent Failures Robot]

5 failures in 2818 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 5

Platform breakdown:

• linux64: 3
• linux32: 1
• osx-10-10: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1532328&startday=2019-03-04&endday=2019-03-10&tree=all

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Yeah, I think we should extend these probes another 6 months.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Attachment: Data review request

Hi liuche,

Normally, I'd ask chutten for data-review here, but he's on PTO. Are you the right person to forward this request to extend some probes to?

Comment 7

[Chenxia Liu [:liuche]]

Comment on attachment 9050425 [details]
Data review request

r+ for extension
# Data Review Form (to be filled by Data Stewards)

1) Is there or will there be **documentation** that describes the schema for the ultimate data set available publicly, complete and accurate?
Yes, in Histograms.json in bug 1488952

2) Is there a control mechanism that allows the user to turn the data collection on and off? 
Yes, data controls in Firefox

3) If the request is for permanent data collection, is there someone who will monitor the data over time?**
No, extend 6mo

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?  **
Type 2

5) Is the data collection request for default-on or default-off?
Pre-release

6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc.  See the appendix for more details)?
No

7) Is the data collection covered by the existing Firefox privacy notice?
Yes

8) Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No) (If yes, set a todo reminder or file a bug if appropriate)**
Expires

9) Does the data collection use a third-party collection tool? 
No

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1532328 - Extend FX_TAB_CLOSE_ probes for another 6 months. data-review=liuche, r?nhnt11

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/87ea67b789a3
Extend FX_TAB_CLOSE_ probes for another 6 months. data-review=liuche, r=nhnt11

Comment 10

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/87ea67b789a3

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed in latest version increase simulation: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=8629ae9d99a51ec035845f25f42e4c51670cb352