1532402 - Avoid using the no-argument version of nsContentUtils::ShouldResistFingerprinting() in Navigator.cpp

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, enhancement)

Comment 1

[(no longer active)]

Attachment: Bug 1532402 - Part 1: Pass a docshell pointer to nsContentUtils::ShouldResistFingerprinting() in the user-agent spoofing code for the Navigator properties;

Comment 2

[(no longer active)]

Attachment: Bug 1532402 - Part 2: Add a variant of nsContentUtils::ShouldResistFingerprinting() which accepts an nsIPrincipal* argument;

We can use this variant in cases where we don't know anything about the
provenant source of the check except its principal.

The principal may not be enough information in the future but at least
porting call sites to this variant will allow us to have a small number
of functions to extend in the future when we want to enable enabling
fingerprinting resistance in certain frames (e.g. third-party tracking
frames.)

Depends on D21990

Comment 3

[(no longer active)]

Attachment: Bug 1532402 - Part 3: Pass a principal pointer nsContentUtils::ShouldResistFingerprinting() in the user-agent spoofing code for the rest of the Navigator properties;

Depends on D21991

Comment 4

[(no longer active)]

Attachment: Bug 1532402 - Part 4: Pass a docshell pointer to nsContentUtils::ShouldResistFingerprinting() for Navigator.maxTouchPoints;

Depends on D21992

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/589d985b3cfe
Part 1: Pass a docshell pointer to nsContentUtils::ShouldResistFingerprinting() in the user-agent spoofing code for the Navigator properties; r=baku
https://hg.mozilla.org/integration/autoland/rev/ed1e303084c4
Part 2: Add a variant of nsContentUtils::ShouldResistFingerprinting() which accepts an nsIPrincipal* argument; r=baku
https://hg.mozilla.org/integration/autoland/rev/6df23def6c36
Part 3: Pass a principal pointer nsContentUtils::ShouldResistFingerprinting() in the user-agent spoofing code for the rest of the Navigator properties; r=baku
https://hg.mozilla.org/integration/autoland/rev/135025f2d2c0
Part 4: Pass a docshell pointer to nsContentUtils::ShouldResistFingerprinting() for Navigator.maxTouchPoints; r=baku

Comment 6

[Cristian Brindusan [:cbrindusan]]

Backed out 4 changesets (Bug 1532402) for assertion failures at Navigator.cpp.

Backout: https://hg.mozilla.org/integration/autoland/rev/b28187cd9146f568efa3d4a07a0715594388cda2

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=135025f2d2c03a2b71b5dcaea31fcda2a1da1358&selectedJob=231964843

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=231964843&repo=autoland&lineNumber=37433

Comment 7

[Cristian Brindusan [:cbrindusan]]

There are also marionette failures:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=231969500&repo=autoland&lineNumber=1587

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/975cde7ee79a
Part 1: Pass a docshell pointer to nsContentUtils::ShouldResistFingerprinting() in the user-agent spoofing code for the Navigator properties; r=baku
https://hg.mozilla.org/integration/autoland/rev/ae40b04ca98b
Part 2: Add a variant of nsContentUtils::ShouldResistFingerprinting() which accepts an nsIPrincipal* argument; r=baku
https://hg.mozilla.org/integration/autoland/rev/53f514ed4989
Part 3: Pass a principal pointer nsContentUtils::ShouldResistFingerprinting() in the user-agent spoofing code for the rest of the Navigator properties; r=baku
https://hg.mozilla.org/integration/autoland/rev/152b9d59cb29
Part 4: Pass a docshell pointer to nsContentUtils::ShouldResistFingerprinting() for Navigator.maxTouchPoints; r=baku

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/975cde7ee79a
https://hg.mozilla.org/mozilla-central/rev/ae40b04ca98b
https://hg.mozilla.org/mozilla-central/rev/53f514ed4989
https://hg.mozilla.org/mozilla-central/rev/152b9d59cb29