1532415 - `moz-phab` commands (submit, uplift etc) should support git range syntax

Status: NEW

(Conduit :: moz-phab, enhancement, P3)

Description

[Nathan Froyd [:froydnj]]

Given my history with git bz, I tried:

froydnj@hawkeye:~/src/gecko$ moz-phab submit cc9da25^..
Upgrading libphutil...
Upgrading arcanist...
Updated! Your copy of arc is now up to date.
fatal: ambiguous argument 'cc9da25^.....': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
CommandError: command 'git' failed to complete successfully
froydnj@hawkeye:~/src/gecko$ moz-phab submit cc9da25^..HEAD
fatal: ambiguous argument 'cc9da25^..HEAD...': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
CommandError: command 'git' failed to complete successfully

until I figured out that you actually need separate arguments for the start and end revision. A single argument for a revision range should be supported as well.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

As someone who has been trying out moz-phab recently (coming from phlay), this is something which I find myself tripping up on quite frequently. Would y'all be open to a patch adding support for commit range syntax?

For me this would ideally come with a config option to effectively make --single the default, so that submit cc9da25.. would submit the stack after that commit, and submit cc9da25 would submit just that commit. I can imagine that could make the help text confusing though.