Use ValueType in BaselineIC's TypeCheckPrimitiveSetStub

RESOLVED FIXED in Firefox 67

Status

()

enhancement
P1
normal
RESOLVED FIXED
3 months ago
2 months ago

People

(Reporter: evilpie, Assigned: evilpie)

Tracking

unspecified
mozilla67
Points:
---

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 months ago

I feel like in this specific case ValueType doesn't improve the situation very much, because the bit flag system already makes everything kind of annoying. Especially for ValidFlags I would like some ideas on how to do that exhaustively. (i.e. note the gap between JSVAL_TYPE_BIGINT and JSVAL_TYPE_OBJECT that we don't even detect)

Priority: -- → P1

Comment 2

2 months ago
Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/cce35becf719
Use ValueType in BaselineIC's TypeCheckPrimitiveSetStub. r=mgaudet

Comment 3

2 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.