153243 - Error in recipient certificate availability checking, causing unreadable mail

Status: VERIFIED FIXED

(MailNews Core :: Security: S/MIME, defect, P1)

Description

[Kai Engert (:KaiE:)]

Compose a mail message.
Enable encryption.
Add a first recipient for whom you have a valid recipient certificate.
Add a second recipient, for whom you have not.

Actual behaviour: The message will be sent. The message will not be readable by
the second recipient.

Expected behaviour: Mozilla should not send the message, but show an error message.

Comment 1

[Kai Engert (:KaiE:)]

Attachment: Fix

This was a silly bug introduced by the patch from 130692.

The input data was a char* buffer, that contained multiple zero terminated
strings after each other. The logic already iterated over them one after
another.

The patch in bug 130692 tried to copy the source data into a string class
object, in order to convert to lowercase. But clearly this only copies the
first recipient address, not the whole input data.

The solution is to simply move the lowercase conversion into the loop iterating
over all recipients.

Comment 2

[Stephane Saux]

Comment on attachment 88563 [details] [diff] [review]
Fix

r=ssaux

Comment 3

[jag (Peter Annema)]

Comment on attachment 88563 [details] [diff] [review]
Fix

sr=jag

Comment 4

[Kai Engert (:KaiE:)]

Checked in to trunk.

Comment 5

[Jaime Rodriguez, Jr.]

charles - can you pls verify this fix on the trunk? thanks!

Comment 6

[Kai Engert (:KaiE:)]

*** Bug 146666 has been marked as a duplicate of this bug. ***

Comment 7

[Charles Rosendahl]

verified on the 0621 trunk builds - now works as specified by design.

Used multiple recipients in a combination of orders, both valid and invalid, of
varying recipient types.

Comment 8

[Jaime Rodriguez, Jr.]

adt1.0.1 (on ADT's behalf) approval for checkin to the 1.0 branch, pending
drivers' approval. pls check this in asap, then add the "fixed1.0.1" keyword.

Comment 9

[Kai Engert (:KaiE:)]

Marking as regression, because this bug was introduced with 130692, and is not
contained in Mozilla 1.0.

Comment 10

[Judson Valeski]

please checkin to the 1.0.1 branch. once there, remove the "mozilla1.0.1+"
keyword and add the "fixed1.0.1" keyword.

Comment 11

[Kai Engert (:KaiE:)]

Checked in to 1_0 branch.

Comment 12

[Charles Rosendahl]

same tests as comment #7 using 0625 branch builds