Drop ScrollFrameHelper::ShouldClampScrollPosition
Categories
(Core :: Layout: Scrolling and Overflow, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: hiro, Assigned: hiro)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
The function uses nsLayoutUtils::GetCrossDocParentFrame(), but it won't work in the fission world. That's said, fortunately, ShouldClampScrollPosition() doesn't provide any functionality in these days.
The function was introduced in bug 726817 for B2G stuff and there is no call site of SetClampScrollPosition now and the only one entry point to call the function was nsIFrameLoader.clampScrollPosition which was removed in
https://hg.mozilla.org/mozilla-central/rev/cd9aace7bb96 . We can remove all relevant stuff.
|
Assignee | |
Comment 1•4 years ago
|
||
This was introduced in bug 726817 for B2G stuff and there is no call site of
SetClampScrollPosition now and the only one entry point to call the function
was nsIFrameLoader.clampScrollPosition which was removed in
https://hg.mozilla.org/mozilla-central/rev/cd9aace7bb96 .
ScrollFrameHelper::ShouldClampScrollPosition() had always returned true in both
cases of root and non-root scrollable frames. (In the case of non-root
scrollable, nsFrameLoader.mClampScrollPosition is initially set to true and
nobody changes the value)
Pushed by hikezoe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fb1e1ab7408a Drop clampScrollPoistion stuff. r=kats
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Description
•