1532457 - Crash in [@ mozilla::layers::AsyncImagePipelineManager::HoldUntilNotUsedByGPU]

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Marcia Knous [:marcia]]

This bug is for crash report bp-cd419e23-a786-4139-a406-3e4720190211.

Seen while looking at nightly crash stats: https://bit.ly/2ENSggd. Crashes go back at least far back as 20190210213844. 34 crashes/19 installs as far back as I could search in Socorro, but not super huge volume in the 67 timeframe.

Code was touched in the 65 timeframe in Bug 1500017. ni on :sotaro for insight.

Correlations:

(88.89% in signature vs 10.95% overall) CPU Info = family 6 model 60 stepping 3 [100.0% vs 11.06% if platform = Windows NT]
(88.89% in signature vs 05.17% overall) address = 0x0
(100.0% in signature vs 06.82% overall) "GL Context?" in app_notes = true [100.0% vs 51.32% if process_type = gpu]
(88.89% in signature vs 06.03% overall) "EGL+" in app_notes = true [100.0% vs 51.32% if process_type = gpu]
(100.0% in signature vs 06.81% overall) "GL Context+" in app_notes = true [100.0% vs 51.32% if process_type = gpu]
(88.89% in signature vs 06.06% overall) "EGL?" in app_notes = true [100.0% vs 51.58% if process_type = gpu]
(88.89% in signature vs 02.31% overall) GFX_ERROR ": " = true [100.0% vs 56.58% if process_type = gpu]
(77.78% in signature vs 00.60% overall) GFX_ERROR "Receive IPC close with reason=AbnormalShutdown" = true [87.50% vs 25.79% if process_type = gpu]
(88.89% in signature vs 00.96% overall) process_type = gpu [62.50% vs 00.30% if startup_crash = null]
(55.56% in signature vs 01.06% overall) adapter_driver_version_clean = 4531 [100.0% vs 59.48% if adapter_device_id = 0x041e]
(55.56% in signature vs 01.06% overall) adapter_driver_version = 20.19.15.4531 [100.0% vs 59.48% if adapter_device_id = 0x041e]
(55.56% in signature vs 00.29% overall) adapter_device_id = 0x041e [62.50% vs 03.42% if process_type = gpu]
(55.56% in signature vs 00.74% overall) useragent_locale = vi [62.50% vs 04.47% if process_type = gpu]
(88.89% in signature vs 07.61% overall) Module "dcomp.dll" = true [62.50% vs 04.83% if startup_crash = null]
(55.56% in signature vs 00.04% overall) Addon "{120c75a3-e2fe-466b-a0a5-ad2752a72bbc}" = true
(55.56% in signature vs 00.27% overall) Addon "jid1-r1tDuNiNb4SEww@jetpack" = true
(55.56% in signature vs 99.68% overall) plugin_version = null

Top 10 frames of crashing thread:

0 xul.dll void mozilla::layers::AsyncImagePipelineManager::HoldUntilNotUsedByGPU gfx/layers/wr/AsyncImagePipelineManager.cpp:696
1 xul.dll void mozilla::layers::AsyncImagePipelineManager::ProcessPipelineRendered gfx/layers/wr/AsyncImagePipelineManager.cpp:650
2 xul.dll void mozilla::layers::AsyncImagePipelineManager::ProcessPipelineUpdates gfx/layers/wr/AsyncImagePipelineManager.cpp:627
3 xul.dll nsresult mozilla::detail::RunnableMethodImpl< xpcom/threads/nsThreadUtils.h:1171
4 xul.dll bool MessageLoop::DeferOrRunPendingTask ipc/chromium/src/base/message_loop.cc:450
5 xul.dll MessageLoop::DoWork ipc/chromium/src/base/message_loop.cc:523
6 xul.dll void base::MessagePumpForUI::DoRunLoop ipc/chromium/src/base/message_pump_win.cc:203
7 xul.dll base::MessagePumpWin::Run ipc/chromium/src/base/message_pump_win.h:79
8 xul.dll MessageLoop::RunHandler ipc/chromium/src/base/message_loop.cc:308
9 xul.dll base::Thread::ThreadMain ipc/chromium/src/base/thread.cc:192

Comment 1

[Sotaro Ikeda [:sotaro]]

All GraphicsCriticalError log on windows had "Receive IPC close with reason=AbnormalShutdown". GPU process crash might be related.

Comment 2

[Sotaro Ikeda [:sotaro]]

Current AsyncImagePipelineManager does not handle a case well that TextureHost is not WebRenderTextureHost. It did not cause the problem before Bug 1500017. Though in normal situation, it does not happen.

Comment 3

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1532457 - Gracefully handle non WebRenderTextureHost case

Comment 4

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=232072421&revision=a893528312a73bd264f1513ff0634f847da87b35

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a8244ddd0c4
Gracefully handle non WebRenderTextureHost case r=nical

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/4a8244ddd0c4