1532570 - nsDOMCSSDeclaration::SetProperty should check for the "important" string in a case-insensitive way.

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, enhancement, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

i.e., this should work:

document.body.style.setProperty("background-color", "red", "ImPoRtAnT");

This is a one-line change, and needs a test (if there is none already). Looks like a good first bug to me :)

Comment 1

[hardik tyagi [:hrdktg]]

Hey Emilio,
I found the change that needs to be done by looking up the docs.

I hope this is what needs to be done>>

} else if (aPriority.LowerCaseEqualsLiteral("important")) {

in declaration of nsDOMCSSDeclaration::SetProperty(...)

If that is fine, can you point me to a reference on writing test case for this particular case.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

It needs to be LowerCaseEqualsASCII, but yeah, that's it! Ideally some pre-existing WPT test would start passing with this change, but apparently there is none, so we could add a test to:

https://searchfox.org/mozilla-central/rev/3e0f1d95fcf8832413457e3bec802113bdd1f8e8/testing/web-platform/tests/css/cssom/css-style-declaration-modifications.html

Let me know if you need more help, thanks for looking into this!

Comment 3

[hardik tyagi [:hrdktg]]

Attachment: Bug 1532570 - nsDOMCSSDeclaration::SetProperty should check for the "important" string in a case-insensitive way. r=emilio

Comment 4

[hardik tyagi [:hrdktg]]

Attachment: Bug 1532570 - nsDOMCSSDeclaration::SetProperty should check for the "important" string in a case-insensitive way. r=emilio

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/edb56e9a487b
nsDOMCSSDeclaration::SetProperty should check for the "important" string in a case-insensitive way. r=emilio

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/edb56e9a487b

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/15754 for changes under testing/web-platform/tests

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged