1532578 - Automatic installation of OpenH264 plugin is broken on Android on Firefox 67

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, defect, P2)

Description

[Dan Minor [:dminor]]

It is working for Firefox 65 and 66, but not with the current Nightly. It appears to check the server, the media.gmp-manager.lastCheck pref is set, but the plugin itself is not actually downloaded. My first guess is that something has happened to break this URL [1].

[1] https://searchfox.org/mozilla-central/source/modules/libpref/init/all.js#5744

Comment 1

[Dan Minor [:dminor]]

URLs match between Firefox 66 and 67. I'll run mozregression.

Comment 2

[Dan Minor [:dminor]]

From Mozregression:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=9311a433ea1beecdb14b2a25ba98d60fb83a4d8c&tochange=56d43815607853dacf7ae7d272912ef3e8927229

56d438156078	Chris Pearce — Bug 1527811 - Hide OpenH264 by default on Windows on ARM. r=dminor,r=Gijs
4afca6b3252e	Chris Pearce — Bug 1527811 - Don't pass appdir and omnijar path to GMP processes. r=bobowen
ad0dfa4133e6	Chris Pearce — Bug 1527811 - Ensure we write the ABI of the GMP we expect to have installed. r=Gijs
aae2bb67624e	Chris Pearce — Bug 1527811 - On Windows on ARM64, add ClearKey GMP to the GMPService in i686 subdir. r=Gijs
83b6c1e3d898	Chris Pearce — Bug 1527811 - Add GMPUtils._isWindowsOnARM64(). r=Gijs
c1e05d18c18e	Chris Pearce — Bug 1527811 - Execute plugin-container.exe for CDM GMP child process in "i686" subdir on Windows on ARM. r=bobowen

I double checked and the download was working fine on my Linux machine.

Comment 3

[Dan Minor [:dminor]]

[Tracking Requested - why for this release]:

This is a recent regression that would prevent us from using OpenH264 on Android.

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

The problem here is the pref changes in https://hg.mozilla.org/integration/mozilla-inbound/rev/56d438156078 needed to be made to mobile.js as well as firefox.js.

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Bug 1532578 - Make OpenH264 visible by default on mobile. r?dminor

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb4c115a9f59
Make OpenH264 visible by default on mobile. r=drno

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/cb4c115a9f59

Comment 8

[Dan Minor [:dminor]]

Installations are working again. Thanks!