1532596 - See if we can remove the RELEASE_OR_BETA ifdefs in platform.cpp

Status: NEW

(Core :: Gecko Profiler, enhancement, P3)

Description

[Florian Quèze [:florian]]

Markus' comment in https://phabricator.services.mozilla.com/D21712#599607
"It's a bit unfortunate how the RELEASE_OR_BETA #ifdefs propagate. Do we have a bug about removing them? Or maybe moving them only to the initialization, so that the rest of the code just sees a null sInstance->mInterposeObserver but is otherwise present even on Beta / Release?"

Comment 1

[Florian Quèze [:florian]]

Could we just enable this code everywhere? Do we have a sense of how much overhead it creates?

Comment 2

[Florian Quèze [:florian]]

If we are not comfortable having this code everywhere, maybe we should still have it in dev edition builds, so that we can have at least some startup main thread I/O coverage for the mozilla-beta tree.

Comment 3

[:Gijs (he/him)]

(In reply to Florian Quèze [:florian] from comment #2)

If we are not comfortable having this code everywhere, maybe we should still have it in dev edition builds, so that we can have at least some startup main thread I/O coverage for the mozilla-beta tree.

For coverage on infra, perhaps we can use xpc::IsInAutomation() or xpc::AreNonLocalConnectionsDisabled() to enable the markers when running on infra but not for users.