Unpinning a tab causes the tab strip to not auto-scroll to it when selecting it from the All Tabs popup / when clicking Ctrl+<tabnumber>

RESOLVED FIXED in Firefox 66

Status

()

defect
P2
normal
RESOLVED FIXED
2 months ago
a month ago

People

(Reporter: itiel_yn8, Assigned: dao)

Tracking

(Depends on 1 bug, {regression})

unspecified
Firefox 67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 wontfix, firefox65 wontfix, firefox66 fixed, firefox67 verified)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 months ago

This is a regression, the range is 2018-02-20 to 2018-02-21. Mozregression is unable to bisect further than that for some reason, so I can't provide the regressor.

STR:

  1. Make the tab strip overflow with tabs
  2. Pin the first tab
  3. Unpin the first tab
  4. Go to the last tab, press Ctrl+1 or select the first tab from the All Tabs popup

AR:
The first tab is selected, but the tab strip is not autoscrolled to the first tab

ER:
The tab strip is autoscrolled.

(Reporter)

Updated

2 months ago
Has Regression Range: --- → yes
Has STR: --- → yes
(Assignee)

Comment 1

2 months ago

(In reply to Itiel from comment #0)

This is a regression, the range is 2018-02-20 to 2018-02-21.

We'll need the exact revisions from these builds.

Priority: -- → P2

Comment 2

2 months ago

Regression window:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=3904c3f9314fd040828c5f1cf1fcc86fd8adfe3e&tochange=4da181c6e0538ece8e10a052f2ff18d914432124

Suspect: 040b6b7bc9f8 Dão Gottwald — Bug 1404469 - Don't take pinned tabs outside of the scrollbox when there are no unpinned tabs. r=Gijs

(Assignee)

Updated

2 months ago
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED

Comment 4

2 months ago
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/2347bb53be3a
Reset _pinnedUnscrollable flag when unpinning a tab. r=Gijs

Comment 5

2 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
(Reporter)

Comment 6

2 months ago

Fixed on latest Nightly.
Dao, I'm guessing this is too late now for an uplift?

Flags: needinfo?(dao+bmo)

It's last minute but we could still take this small change.

(Assignee)

Comment 8

2 months ago

Comment on attachment 9049127 [details]
Bug 1532719 - Reset _pinnedUnscrollable flag when unpinning a tab. r=Gijs

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: bug 1404469
  • User impact if declined: see comment 0
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: see comment 0
  • List of other uplifts needed: -
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): trivial fix
  • String changes made/needed: -
Flags: needinfo?(dao+bmo)
Attachment #9049127 - Flags: approval-mozilla-beta?
(Assignee)

Updated

2 months ago
Depends on: 1533997

Comment on attachment 9049127 [details]
Bug 1532719 - Reset _pinnedUnscrollable flag when unpinning a tab. r=Gijs

Small fix for pinned tab behavior, let's take it for the RC build.

Attachment #9049127 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

I have reproduced this bug with Nightly 67.0a1 (2019-03-05) on Windows 7, 64 Bit. This fix of this bug is verified with latest Beta and latest Nightly!

Build ID : 20190313193404
User Agent : Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:66.0) Gecko/20100101 Firefox/66.0

Build ID : 20190315093917
User Agent : Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:67.0) Gecko/20100101 Firefox/67.0

QA Whiteboard: [bugday-20190313]
You need to log in before you can comment on or make changes to this bug.