1532719 - Unpinning a tab causes the tab strip to not auto-scroll to it when selecting it from the All Tabs popup / when clicking Ctrl+<tabnumber>

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P2)

Description

[Itiel]

This is a regression, the range is 2018-02-20 to 2018-02-21. Mozregression is unable to bisect further than that for some reason, so I can't provide the regressor.

STR:

1. Make the tab strip overflow with tabs
2. Pin the first tab
3. Unpin the first tab
4. Go to the last tab, press Ctrl+1 or select the first tab from the All Tabs popup

AR:
The first tab is selected, but the tab strip is not autoscrolled to the first tab

ER:
The tab strip is autoscrolled.

Comment 1

[Dão Gottwald [:dao]]

(In reply to Itiel from comment #0)

This is a regression, the range is 2018-02-20 to 2018-02-21.

We'll need the exact revisions from these builds.

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=3904c3f9314fd040828c5f1cf1fcc86fd8adfe3e&tochange=4da181c6e0538ece8e10a052f2ff18d914432124

Suspect: 040b6b7bc9f8 Dão Gottwald — Bug 1404469 - Don't take pinned tabs outside of the scrollbox when there are no unpinned tabs. r=Gijs

Comment 3

[Dão Gottwald [:dao]]

Attachment: Bug 1532719 - Reset _pinnedUnscrollable flag when unpinning a tab. r=Gijs

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2347bb53be3a
Reset _pinnedUnscrollable flag when unpinning a tab. r=Gijs

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/2347bb53be3a

Comment 6

[Itiel]

Fixed on latest Nightly.
Dao, I'm guessing this is too late now for an uplift?

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

It's last minute but we could still take this small change.

Comment 8

[Dão Gottwald [:dao]]

Comment on attachment 9049127 [details]
Bug 1532719 - Reset _pinnedUnscrollable flag when unpinning a tab. r=Gijs

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: bug 1404469
• User impact if declined: see comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: see comment 0
• List of other uplifts needed: -
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): trivial fix
• String changes made/needed: -

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9049127 [details]
Bug 1532719 - Reset _pinnedUnscrollable flag when unpinning a tab. r=Gijs

Small fix for pinned tab behavior, let's take it for the RC build.

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0b7f3caba2aa

Comment 11

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 67.0a1 (2019-03-05) on Windows 7, 64 Bit. This fix of this bug is verified with latest Beta and latest Nightly!

Build ID : 20190313193404
User Agent : Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:66.0) Gecko/20100101 Firefox/66.0

Build ID : 20190315093917
User Agent : Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:67.0) Gecko/20100101 Firefox/67.0