Unpinning a tab causes the tab strip to not auto-scroll to it when selecting it from the All Tabs popup / when clicking Ctrl+<tabnumber>

RESOLVED FIXED in Firefox 66



5 months ago
4 months ago


(Reporter: itiel_yn8, Assigned: dao)


(Depends on 1 bug, {regression})

Firefox 67
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 wontfix, firefox65 wontfix, firefox66 fixed, firefox67 verified)



(1 attachment)

This is a regression, the range is 2018-02-20 to 2018-02-21. Mozregression is unable to bisect further than that for some reason, so I can't provide the regressor.


  1. Make the tab strip overflow with tabs
  2. Pin the first tab
  3. Unpin the first tab
  4. Go to the last tab, press Ctrl+1 or select the first tab from the All Tabs popup

The first tab is selected, but the tab strip is not autoscrolled to the first tab

The tab strip is autoscrolled.

Has Regression Range: --- → yes
Has STR: --- → yes

(In reply to Itiel from comment #0)

This is a regression, the range is 2018-02-20 to 2018-02-21.

We'll need the exact revisions from these builds.

Priority: -- → P2

Regression window:

Suspect: 040b6b7bc9f8 Dão Gottwald — Bug 1404469 - Don't take pinned tabs outside of the scrollbox when there are no unpinned tabs. r=Gijs

Assignee: nobody → dao+bmo
Pushed by gijskruitbosch@gmail.com:
Reset _pinnedUnscrollable flag when unpinning a tab. r=Gijs
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67

Fixed on latest Nightly.
Dao, I'm guessing this is too late now for an uplift?

Flags: needinfo?(dao+bmo)

It's last minute but we could still take this small change.

Comment on attachment 9049127 [details]
Bug 1532719 - Reset _pinnedUnscrollable flag when unpinning a tab. r=Gijs

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: bug 1404469
  • User impact if declined: see comment 0
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: see comment 0
  • List of other uplifts needed: -
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): trivial fix
  • String changes made/needed: -
Flags: needinfo?(dao+bmo)
Attachment #9049127 - Flags: approval-mozilla-beta?
Depends on: 1533997

Comment on attachment 9049127 [details]
Bug 1532719 - Reset _pinnedUnscrollable flag when unpinning a tab. r=Gijs

Small fix for pinned tab behavior, let's take it for the RC build.

Attachment #9049127 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

I have reproduced this bug with Nightly 67.0a1 (2019-03-05) on Windows 7, 64 Bit. This fix of this bug is verified with latest Beta and latest Nightly!

Build ID : 20190313193404
User Agent : Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:66.0) Gecko/20100101 Firefox/66.0

Build ID : 20190315093917
User Agent : Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:67.0) Gecko/20100101 Firefox/67.0

QA Whiteboard: [bugday-20190313]
You need to log in before you can comment on or make changes to this bug.