Open Bug 1532723 Opened 5 years ago Updated 2 years ago

Ensure we always pass a valid triggeringPrincipal to internalSave()

Categories

(Core :: DOM: Security, enhancement, P3)

enhancement

Tracking

()

People

(Reporter: ckerschb, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [domsecurity-backlog1])

As a follow up to Bug 1529901 we should ensure that we always pass a valid triggeringPrincipal to internalSave(). That fallback quirks of querying the right Principal [1] makes me quite nervous and we should eliminate those lines. Elsewhere in the code do something like:

if (!triggeringPrincipal) {
throw new Error("Must load with a triggering Principal");
}

[1] https://searchfox.org/mozilla-central/rev/92d11a33250a8e368c8ca3e962e15ca67117f765/toolkit/content/contentAreaUtils.js#432-435

Priority: -- → P3
Whiteboard: [domsecurity-backlog1]
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.