1532773 - Add play, pause, close, and un-pip controls to Picture-in-Picture window player

Status: VERIFIED FIXED

(Toolkit :: Video/Audio Controls, enhancement, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

Attachment: image.png

The Picture-in-Picture window needs to have controls to do the following:

1. Close the Picture-in-Picture window
2. Play / Pause the video
3. Close the Picture-in-Picture window, and return to the tab that the video originated from.

See screenshot.

Comment 1

[mb]

Is there a bug open for adding a progress bar to seek through playback on the PIP window?

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1532773 - starter patch

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Hey JSON_Voorhees,

So I did some scouting ahead on this one, and I have a starter patch that adds a simple close control.

Part of the challenge here is the privileged "-moz-window-dragging" CSS rule that's on the browser element. We have to not apply that on the control items in order to have them be clickable.

I also suspect that :hover is going to be screwed up a little bit by -moz-window-dragging, in case we wanted to use hover events to set opacity on the buttons. We can deal with that when we get there though.

You can apply my starter patch with:

moz-phab patch --apply-to here --no-commit

Any questions on this?

Comment 4

[Dave Justice]

Attachment: Bug 1532773 - Add player controls for PictureInPicture. r?mconley

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8fa27903feba
Add player controls for PictureInPicture. r=mconley

Comment 6

[Andreea Pavel [:apavel]]

Backed out for failing browser_showMessage.js

Push with failures https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&selectedJob=237900165&searchStr=browser%2Cchrome&revision=8fa27903feba34c706e400f6270bc0f712672a45

Failure log https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=237888396&repo=autoland&lineNumber=24418

Backout: https://hg.mozilla.org/integration/autoland/rev/1208afc3481a0b062f957f688f43c103a198069f

Comment 7

[Mike Conley (:mconley) (:⚙️)]

(In reply to Andreea Pavel [:apavel] from comment #6)

Backed out for failing browser_showMessage.js

Huh. That was unexpected. Investigating...

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d040eae4786
Add player controls for PictureInPicture. r=mconley

Comment 9

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/6d040eae4786

Comment 10

[Cristian Craciun]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0
Build ID: 20190527215312

Verified as fixed on Windows 10 with the latest Nightly.