Add play, pause, close, and un-pip controls to Picture-in-Picture window player
Categories
(Toolkit :: Video/Audio Controls, enhancement, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox68 | --- | fixed |
People
(Reporter: mconley, Assigned: davejustishh)
References
Details
Attachments
(2 files, 1 obsolete file)
The Picture-in-Picture window needs to have controls to do the following:
- Close the Picture-in-Picture window
- Play / Pause the video
- Close the Picture-in-Picture window, and return to the tab that the video originated from.
See screenshot.
Reporter | ||
Updated•5 years ago
|
Is there a bug open for adding a progress bar to seek through playback on the PIP window?
Updated•5 years ago
|
Reporter | ||
Comment 2•5 years ago
|
||
Reporter | ||
Comment 3•5 years ago
|
||
Hey JSON_Voorhees,
So I did some scouting ahead on this one, and I have a starter patch that adds a simple close control.
Part of the challenge here is the privileged "-moz-window-dragging" CSS rule that's on the browser element. We have to not apply that on the control items in order to have them be clickable.
I also suspect that :hover is going to be screwed up a little bit by -moz-window-dragging, in case we wanted to use hover events to set opacity on the buttons. We can deal with that when we get there though.
You can apply my starter patch with:
moz-phab patch --apply-to here --no-commit
Any questions on this?
Assignee | ||
Comment 4•5 years ago
|
||
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8fa27903feba Add player controls for PictureInPicture. r=mconley
Comment 6•5 years ago
|
||
Backed out for failing browser_showMessage.js
Failure log https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=237888396&repo=autoland&lineNumber=24418
Backout: https://hg.mozilla.org/integration/autoland/rev/1208afc3481a0b062f957f688f43c103a198069f
Reporter | ||
Comment 7•5 years ago
|
||
(In reply to Andreea Pavel [:apavel] from comment #6)
Backed out for failing browser_showMessage.js
Huh. That was unexpected. Investigating...
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6d040eae4786 Add player controls for PictureInPicture. r=mconley
Comment 9•5 years ago
|
||
bugherder |
Comment 10•5 years ago
|
||
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0
Build ID: 20190527215312
Verified as fixed on Windows 10 with the latest Nightly.
Assignee | ||
Updated•5 years ago
|
Updated•6 months ago
|
Description
•