1532783 - Switch to using aliases for worker-types in taskgraph.

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Tom Prince [:tomprince]]

There are a number of ways we want to vary workers over time and jobs, including

• we are working on migrating to gce
• mac pgo builds have a dedicated worker-type for level 3 but not level 1

Rather than have all tasks know about how the machines are provisioned, we should move to using short-names for the worker types, and then have a config mapping those to the actual worker types.

This will probably subsume taskgraph.util.worker_types eventually.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

💖!

A few extra thoughts:

• it'd be great to have this in ci-configuration, so that we can change workerType names across all repos simultaneously

• it'd be great to allow overriding this in a try push (maybe by just supplying a URL to a different worker-types.yml?)

  For Windows workerTypes, pmoore and grenade often do try pushes to run builds/tests on "beta" workertypes. That's a nice model and it would be great to support it more naturally.

• it'd be great if this could later be expanded to allow proportional allocation

  When we upgraded mac tests from buildbot + buildbot-bridge to taskcluster workers, we reformatted them in batches, and added some custom code that would send N% of requests to the old worker-type and (100-N)% to the new worker-types. We did so in a stable fashion (so that a particular task was always on the same worker-type).

Comment 2

[Tom Prince [:tomprince]]

Attachment: Bug 1532783: [taskgraph] Set worker `os` and `implementation` earlier in job transform; r?dustin

This slightly decreases the amount of code that needs to know how to determine this.

Comment 3

[Tom Prince [:tomprince]]

Attachment: Bug 1532783: [taskgraph] Move handling of windows scopes to taskgraph.transfroms.task; r?dustin

Currently the scopes are handled in some test-specific code. However, there is
logic not to be in generic code.

Comment 4

[Tom Prince [:tomprince]]

Some of those sound like useful ideas, and some of them I'm not sure of. I will keep the surface area of the code that care about the mapping to real names small, so that we can extend it to handle some of those use cases easier in the future.

Comment 5

[Tom Prince [:tomprince]]

Attachment: Bug 1532783: Implement worker aliases;

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/421bdcc103d3
[taskgraph] Set worker `os` and `implementation` earlier in job transform; r=dustin
https://hg.mozilla.org/integration/autoland/rev/722b3915da31
[taskgraph] Move handling of windows scopes to taskgraph.transfroms.task; r=dustin

Comment 7

[Narcis Beleuzu [:NarcisB]]

Backed out for causing Gecko Decision Task bustage.

Backout link: https://hg.mozilla.org/integration/autoland/rev/54ed5eac2abca2519704c74bc5c421b846031504
Push link: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&selectedJob=232597820&revision=722b3915da319bd9cab0a9f2a43c18b75585ffec
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=232592511&repo=autoland&lineNumber=3859

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b1f78426763
[taskgraph] Set worker `os` and `implementation` earlier in job transform; r=dustin
https://hg.mozilla.org/integration/autoland/rev/29168c60c4e6
[taskgraph] Move handling of windows scopes to taskgraph.transfroms.task; r=dustin

Comment 9

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/6b1f78426763
https://hg.mozilla.org/mozilla-central/rev/29168c60c4e6

Comment 10

[Tom Prince [:tomprince]]

:dustin, I've included a sketch of what I'm thinking, can you have look over it, and see if you think it is reasonable?

Comment 11

[Tom Prince [:tomprince]]

Attachment: Bug 1532783: Add worker types for running instrumented builds;

This adds worker-type alias that has dedicated workers at level-3 for running
instrumented builds, but uses a test worker type at other levels.

Comment 12

[Phabricator Automation]

Comment on attachment 9051101 [details]
Bug 1532783: Add worker types for running instrumented builds;

Revision D23576 was moved to bug 1535132. Setting attachment 9051101 [details] to obsolete.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4eabf4f36fef
Implement worker aliases; r=aki,glandium,jmaher,dustin

Comment 14

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/4eabf4f36fef

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2120bf85232a
Port bug 1532783 - Implement worker aliases. rs=bustage-fix

Comment 16

[Jorg K (CEST = GMT+2)]

Hi all, Rob isn't here so I pushed this with a "selection" of workers that sounded familiar. AFAIK, TB doesn't do android, PGO and aarch64 also seemed unfamiliar.

Can you please let me know what I should add or subtract.

Comment 17

[Tom Prince [:tomprince]]

Attachment: Bug 1532783: [taskgraph] Switch to using worker aliases for docker-worker and generic-worker; r?dustin

Comment 18

[Tom Prince [:tomprince]]

Attachment: Bug 1532783: [taskgraph] Remove entries from WORKER_TYPES that correspond to workers with aliases; r?dustin

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cef374e9b298
[taskgraph] Switch to using worker aliases for docker-worker and generic-worker; r=dustin
https://hg.mozilla.org/integration/autoland/rev/49006e43876f
[taskgraph] Remove entries from WORKER_TYPES that correspond to workers with aliases; r=dustin

Comment 20

[Tom Prince [:tomprince]]

Attachment: Bug 1532783: [taskgraph] Fix lint error.

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/96a1f7afe8ae
[taskgraph] Fix lint error.

Comment 22

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/cef374e9b298
https://hg.mozilla.org/mozilla-central/rev/49006e43876f
https://hg.mozilla.org/mozilla-central/rev/96a1f7afe8ae

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0d3f162fe5bb
Port bug 1532783: [taskgraph] Switch to using worker aliases for docker-worker and generic-worker. rs=bustage-fix