Closed Bug 1532810 Opened 9 months ago Closed 9 months ago

Add profiler markers for long-running GL calls

Categories

(Core :: Graphics: WebRender, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: bholley, Assigned: bholley)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

CPU time spent in GL calls is not always the most important indicator of performance, but it's certainly one important dimension. In bug 1531183, we have a GL driver that won't let us unwind the stack to get profiler samples, leaving us guessing as to what the samples correspond to.

Instead of jumping through hoops to solve that problem, we can simply feed this information to the profiler directly via markers when the call runs longer than a given threshold. We can do this only when the thread is actively being profiled to avoid any risk of slowing down WebRender in the wild.

Depends on D22200

Attachment #9048687 - Attachment is obsolete: true
Pushed by bholley@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/866b6d9949a8
Update Cargo.lock to fix wrench bustage on a CLOSED TREE. r=me
Backout by shindli@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef858f297370
Backed out 3 changesets for wrench bustages CLOSED TREE
Attachment #9048688 - Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.