1532810 - Add profiler markers for long-running GL calls

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Bobby Holley (:bholley)]

CPU time spent in GL calls is not always the most important indicator of performance, but it's certainly one important dimension. In bug 1531183, we have a GL driver that won't let us unwind the stack to get profiler samples, leaving us guessing as to what the samples correspond to.

Instead of jumping through hoops to solve that problem, we can simply feed this information to the profiler directly via markers when the call runs longer than a given threshold. We can do this only when the thread is actively being profiled to avoid any risk of slowing down WebRender in the wild.

Comment 1

[Bobby Holley (:bholley)]

Attachment: Bug 1532810 - Generalize LongTaskMarkerPayload for other inteval-oriented use cases.

Comment 2

[Bobby Holley (:bholley)]

Attachment: Bug 1532810 - Add a wrapper in gleam to time each gl call.

Depends on D22200

Comment 3

[Bobby Holley (:bholley)]

Attachment: Bug 1532810 - Report long-running GL calls to the profiler.

Depends on D22201

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/24b9ae45e4fa
Update gleam. r=me
https://hg.mozilla.org/integration/mozilla-inbound/rev/1cb006402562
Report long-running GL calls to the profiler. r=gw

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/866b6d9949a8
Update Cargo.lock to fix wrench bustage on a CLOSED TREE. r=me

Comment 6

[Stefan Hindli [:stefan_hindli]]

Backed out 3 changesets (Bug 1532810) for wrench bustages CLOSED TREE

Failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=232709020

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=232709020&repo=mozilla-inbound&lineNumber=237

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef858f297370
Backed out 3 changesets for wrench bustages CLOSED TREE

Comment 8

[Bobby Holley (:bholley)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f0006c83d173a985dd7c5765fc9fe4506d2a9235

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8426cec31aae
Update gleam. r=me
https://hg.mozilla.org/integration/mozilla-inbound/rev/1972b8836948
Report long-running GL calls to the profiler. r=gw

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/8426cec31aae
https://hg.mozilla.org/mozilla-central/rev/1972b8836948