1532927 - Multi-byte opcodes are not actually byte + byte but byte + leb128

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, enhancement, P3)

Description

[Lars T Hansen [:lth]]

I believe this reached consensus a long time ago but it's not been an issue until SIMD: for a prefixed operation, the secondary opcode is not a byte but a leb128, yet we read it as a byte. This must change.

Comment 1

[Lars T Hansen [:lth]]

Attachment: Bug 1532927 - Secondary wasm opcodes are not bytes. r?luke

Changes to decoding, dispatch, and encoding to handle a uint32_t representation
for the secondary opcode.

Also a drive-by fix to remove an orphaned enum in WasmTypes.h

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/9cd8b6db0567
Secondary wasm opcodes are not bytes.  r=luke

Comment 3

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/9cd8b6db0567