[Wayland][WebRender] Use headless context in RenderCompositorEGL

RESOLVED FIXED in Firefox 67

Status

()

enhancement
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: sotaro, Assigned: sotaro)

Tracking

(Blocks 3 bugs)

unspecified
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

3 months ago

RenderCompositorEGL does not use headless context for now. It is better to use headless context.

Assignee

Updated

3 months ago
Assignee: nobody → sotaro.ikeda.g
Summary: Use headless context in GLContextProviderEGL → Use headless context in RenderCompositorEGL
Assignee

Updated

3 months ago
Depends on: 1532942
Assignee

Updated

3 months ago
Assignee

Updated

3 months ago
Blocks: wayland, wr-linux
Assignee

Comment 1

3 months ago
Posted patch wip (obsolete) — Splinter Review
Assignee

Updated

3 months ago
Summary: Use headless context in RenderCompositorEGL → [Wayland][WebRender] Use headless context in RenderCompositorEGL
Assignee

Updated

3 months ago
Attachment #9048801 - Attachment is obsolete: true
Assignee

Comment 3

3 months ago

attachment 9049083 [details] seemed to work well on Wayland. But without stencil, rendering caused flickering.

:gw, do you have any ideas about why the rendering caused flickering without stencil with WebRender on Wayland?

Flags: needinfo?(gwatson)
Assignee

Updated

3 months ago
No longer blocks: 1532929
Assignee

Comment 4

3 months ago

Used "GDK_BACKEND=wayland ./mach run" for testing on Ubuntu 18.

Comment 5

3 months ago

No, that's unexpected. Like you said, WR doesn't rely on stencil buffer anywhere that I'm aware of. I think it's probably OK to enable stencil for now, though, if that fixes it. I believe normal Gecko on Linux also has stencil enabled (at least, I recall seeing a stencil buffer present in apitrace debugging).

Flags: needinfo?(gwatson)
Assignee

Comment 6

3 months ago

Thanks! GLContextProviderEGL::CreateForCompositorWidget() and GLContextEGL::CreateEGLPBufferOffscreenContext() uses a different function for choosing EGLConfig. It seems safer to use CreateForCompositorWidget() one for now.

Attachment #9049083 - Attachment description: Bug 1532949 - Use headless context in RenderCompositorEGL → Bug 1532024 - Explicityly create headless context for webrender in RenderCompositorEGL
Assignee

Updated

3 months ago
Blocks: 1532929

Comment 7

3 months ago
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a0767cb93359
Bug 1532024 - Explicityly create headless context for webrender in RenderCompositorEGL r=jgilbert
Attachment #9049083 - Attachment description: Bug 1532024 - Explicityly create headless context for webrender in RenderCompositorEGL → Bug 1532949 - Explicityly create headless context for webrender in RenderCompositorEGL

Comment 8

3 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.