Closed Bug 1532949 Opened 5 years ago Closed 5 years ago

[Wayland][WebRender] Use headless context in RenderCompositorEGL

Categories

(Core :: Graphics: WebRender, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

(Blocks 3 open bugs)

Details

Attachments

(1 file, 1 obsolete file)

RenderCompositorEGL does not use headless context for now. It is better to use headless context.

Assignee: nobody → sotaro.ikeda.g
Summary: Use headless context in GLContextProviderEGL → Use headless context in RenderCompositorEGL
Depends on: 1532942
Blocks: wayland, wr-linux
Attached patch wip (obsolete) — Splinter Review
Summary: Use headless context in RenderCompositorEGL → [Wayland][WebRender] Use headless context in RenderCompositorEGL
Attachment #9048801 - Attachment is obsolete: true

attachment 9049083 [details] seemed to work well on Wayland. But without stencil, rendering caused flickering.

:gw, do you have any ideas about why the rendering caused flickering without stencil with WebRender on Wayland?

Flags: needinfo?(gwatson)
No longer blocks: 1532929

Used "GDK_BACKEND=wayland ./mach run" for testing on Ubuntu 18.

No, that's unexpected. Like you said, WR doesn't rely on stencil buffer anywhere that I'm aware of. I think it's probably OK to enable stencil for now, though, if that fixes it. I believe normal Gecko on Linux also has stencil enabled (at least, I recall seeing a stencil buffer present in apitrace debugging).

Flags: needinfo?(gwatson)

Thanks! GLContextProviderEGL::CreateForCompositorWidget() and GLContextEGL::CreateEGLPBufferOffscreenContext() uses a different function for choosing EGLConfig. It seems safer to use CreateForCompositorWidget() one for now.

Attachment #9049083 - Attachment description: Bug 1532949 - Use headless context in RenderCompositorEGL → Bug 1532024 - Explicityly create headless context for webrender in RenderCompositorEGL
Blocks: 1532929
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a0767cb93359
Bug 1532024 - Explicityly create headless context for webrender in RenderCompositorEGL r=jgilbert
Attachment #9049083 - Attachment description: Bug 1532024 - Explicityly create headless context for webrender in RenderCompositorEGL → Bug 1532949 - Explicityly create headless context for webrender in RenderCompositorEGL
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: