1533029 - The warning displayed when attempting to save an address is displayed on 2 rows with the default settings

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, defect, P3)

Description

[Daniel Bodea [:danibodea]]

Note

• When reaching the Add New Address modal (from browser Options, Privacy & Security, Forms Autofill section, Saved Addresses modal, Add... button is pressed), it can be observed that the warning "Form Autofill is currently available only for certain countries." is displayed on 2 rows.
• I would like to suggest that the warning is displayed on the next row altogether. This way it will be displayed on a single row and it will be more easily read.

Affected versions

• Nightly v67.0a1
• Beta v66.0b13
• Release v65.0.2

Affected platforms

• Windows 10
• Ubuntu 18.04 LTS

Prerequisites

1. Go to about:config and give pref "browser.search.region" value "US".
2. Go to about:config and give pref "extensions.formautofill.available" value "on".
3. Restart the browser for the changes to take effect.

Steps to reproduce

1. Open browser.
2. Open "about:preferences#privacy"
3. Scroll to Forms & Autofill section.
4. Click on the "Saved Addresses..." button.
5. Click on "Add..." button.
6. Observe the warning displayed at the right of the "Cancel" and "Save" buttons.

Expected result

• The warning is displayed on a single row and it's easy to read.

Actual result

• The warning message is displayed on 2 rows because it does not fit in the same row with the buttons (using default settings).

Comment 1

[Daniel Bodea [:danibodea]]

Attachment: The warning message is displayed on 2 rows.png

The warning message is displayed on 2 rows on Windows and Ubuntu with generic/default settings.

Comment 2

[Sam Foster [:sfoster] (he/him)]

I think this may have been a regression, but regardless, the #controls-container should be using flex-box to ensure the warning message wraps within its own column.

Comment 3

[Jayati Shrivastava]

Hello, May I work on this?

Comment 4

[Jayati Shrivastava]

Attachment: Bug 1533029 - Add flex display for correct rendering of warning. r=sfoster

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd16b76a0c7b
Add flex display for correct rendering of warning. r=sfoster

Comment 6

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/dd16b76a0c7b

Comment 7

[Cristian Baica [:cbaica], Release Desktop QA]

I have managed to reproduce the issue using Fx67.0a1 buildID: 20190306161300.
The issue is verified fixed using Fx77.0a1 and Fx76.0b4 on Windows 10 x64 and Ubuntu 18.04. The warning is now correctly aligned with the form, in a tiddier format.