Closed Bug 1533053 Opened 6 years ago Closed 6 years ago

Add more automated tests to check switching between feature v.s. addon CFR templates

Categories

(Firefox :: Messaging System, enhancement, P1)

Product:
Firefox
Component:
Messaging System
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 68
Iteration:
68.2 - Apr 1 - 14
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: k88hudson, Assigned: andreio)

References

Details

(Keywords: github-merged)

Attachments

(1 file)

Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4842
52 bytes, text/x-github-pull-request
Details | Review

Because there is potential for certain elements to get left around or hidden accidentally, I think we could use some automated tests checking something like:

  • Show an add-on CFR
  • Show a feature CFR

And vice versa.

That way we can do some refactoring of the DOM structure without worrying too much about stuff not being there. Probably makes sense as a mochi test.

Assignee: nobody → andrei.br92
Iteration: --- → 67.4 - Mar 11 - 17
Blocks: pinned-tabs-68
No longer blocks: 1501751
Priority: P2 → P1
Iteration: 67.4 - Mar 11 - 17 → 68.1 - Mar 18 - 31
Iteration: 68.1 - Mar 18 - 31 → 68.2 - Apr 1 - 14
Blocks: 1541502

https://hg.mozilla.org/mozilla-central/rev/7a266c35cb30

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox68: --- → fixed
Keywords: github-merged
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Component: Activity Streams: Newtab → Messaging System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: