1533062 - Potentially extra OS_LIBS in SeaMonkey and Thunderbird moz.build

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Ian Neal]

In Bug 1302855 - Fold browsercomps into xul, the adding of OS_LIBS was removed from browser/components/build/moz.build - https://hg.mozilla.org/releases/mozilla-esr60/diff/4006b190b344/browser/components/build/moz.build
This was not done in the equivalent bug for SM (Bug 1318735) or in TB, so they still exist in:
https://dxr.mozilla.org/comm-esr60/source/suite/components/shell/moz.build#29
https://dxr.mozilla.org/comm-esr60/source/mail/components/build/moz.build#19
Potentially these could be removed.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1533062-oslibs.patch

[Approval Request Comment]
Regression caused by (bug #): 1302855
User impact if declined: --
Testing completed (on c-c, etc.): c-r (2.53) c-esr60 2.57
Risk to taking this patch (and alternatives if risky): No risk. Either linking works or it does not.

Comment 2

[Frank-Rainer Grahl (:frg)]

Attachment: 1533062-oslibs-mail.patch

Did a comm-esr60 TB build so should be good for comm-central too.

Comment 3

[Ian Neal]

Comment on attachment 9049745 [details] [diff] [review]
1533062-oslibs.patch

r/a=me though for some reason I have lost the permission to a+ on MailNews

Comment 4

[Ian Neal]

Comment on attachment 9049745 [details] [diff] [review]
1533062-oslibs.patch

[Triage Comment]
a=me for SM parts

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a0f38b03730f
Remove os libraries from SeaMonkey Windows shell link step. r=IanN

Comment 6

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9049745 [details] [diff] [review]
1533062-oslibs.patch

https://hg.mozilla.org/releases/comm-esr60/rev/8a1c6dc80b4cd2f8800e38c791ea9b81ae0d7713

Comment 7

[Jorg K (CEST = GMT+2)]

Comment on attachment 9049747 [details] [diff] [review]
1533062-oslibs-mail.patch

Thanks.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bca07912f1dd
Remove os libraries from Thunderbird Windows link step. r=jorgk

Comment 9

[Frank-Rainer Grahl (:frg)]

Fixed 2.53.1
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/d6bd51a133d3e83cc2c73cf2e80088d3de79f255