Closed Bug 1533167 Opened 2 years ago Closed 2 years ago

Move LoginFormFactory to its own file

Categories

(Toolkit :: Password Manager, enhancement, P3)

Product:
Toolkit
Component:
Password Manager
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: MattN, Assigned: MattN)

References

(Blocks 1 open bug)

Details

(Whiteboard: [passwords:tech-debt])

Attachments

(1 file)

Bug 1533167 - Move LoginFormFactory to its own file. r=jaws
47 bytes, text/x-phabricator-request
Details | Review

LoginManagerContent is harder to maintain because it contains too many top-level objects. Now that we don't have the compartment overhead of splitting JSMs we can move LoginFormFactory to its own JSM. This may also give some memory improvements since there are times where we need LoginFormFactory but not LoginManagerContent such as here.

Blocks: 1533176
Assignee: nobody → MattN+bmo
Status: NEW → ASSIGNED
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/3260913ff01a
Move LoginFormFactory to its own file. r=jaws

https://hg.mozilla.org/mozilla-central/rev/3260913ff01a

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.