1533172 - Side-loaded extensions are not prompted to be enabled for private browsing

Status: VERIFIED FIXED

(WebExtensions :: General, defect, P1)

Description

[Jon Wiles]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:65.0) Gecko/20100101 Firefox/65.0

Steps to reproduce:

sudo cp $myext '/usr/share/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/
firefox-nightly &

Actual results:

Firefox started, prompted me to enable the side-loaded extension, but never said a word about private mode. The extension did not have private mode access.

Expected results:

Arguably, a prompt for access to private mode should be given at installation time, similar to the prompt given for web-installed extensions.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1533172 - Show post install notification when enabling sideload extensions. r?mixedpuppy!

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9360ad3c2e0fe5ac3189092e7dfb7c9a212b3bcc

Comment 3

[Shane Caraveo (:mixedpuppy)]

Can we get a good manual STR for this as well?

Comment 4

[David Durst [:ddurst]]

I want to be really clear on the issue we're looking at here: is this only about private mode, or about sideloading in general? This is filed against the 67 branch, but the user agent implies a version prior to the private browsing mode changes.

Comment 5

[David Durst [:ddurst]]

(Also, I want to be clear on whether sideloading fails, or it's just about having the option to enable the extension for PBM, as Shane's test yesterday failed to even sideload, iirc.)

Comment 6

[Jon Wiles]

Sideloading succeeds. The issue is that after sideloading succeeds, the extension is not allowed in private windows, and the user is never prompted to make a decision about that, unlike what occurs when an extension is installed from AMO.

If it is helpful, I can attach a sideloaded extension, but any signed extension will do.

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Distribution_options/Sideloading_add-ons documents the extension folders for each platform.

Comment 7

[Jon Wiles]

Also, bug 1533638 has a test case that demonstrates sideloading; might be of some use in this bug too.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9bc49a9e915a
Show post install notification when enabling sideload extensions. r=mixedpuppy,kmag

Comment 9

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/9bc49a9e915a

Comment 10

[CosminB]

Attachment: Bug1533172.gif

I was able to reproduce the issue on Firefox 67.0b5 (20190325125126) under Win 7 64-bit and Mac OS X 10.14.1.

This issue is verified as fixed on Firefox 68.0a1 (20190326095147) under Win 7 64-bit and Mac OS X 10.14.1.

Please see the attached video.

Comment 11

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 9049510 [details]
Bug 1533172 - Show post install notification when enabling sideload extensions. r?mixedpuppy!

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: Bug 1380809
• User impact if declined: Sideloaded extensions require two manual steps by the user to enable and turn on in private windows. This makes the post install panel appear for those situations after the user has enabled the extension, making UX better for the user.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): minimal change limited to sideloaded extensions
• String changes made/needed: none

Comment 12

[Pascal Chevrel:pascalc]

Comment on attachment 9049510 [details]
Bug 1533172 - Show post install notification when enabling sideload extensions. r?mixedpuppy!

Less confusing UX for our we bextention changes in private browsing mode, has tests and was verified on Nightly by QA, uplift approved for 67 beta 6, thanks.

I'd like it to be verified by QA in Beta as well.

Comment 13

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/dccd60f0b7ba

Comment 14

[CosminB]

Attachment: Bug1533172-Beta.gif

This issue is verified as fixed on Firefox 67.0b6 (20190328152334) under Win 7 64-bit and Mac OS X 10.14.1.

Please see the attached video.