Stop using --panel-disabled-color for subviewbutton shortcuts (where the subviewbutton is also a menuitem)

RESOLVED FIXED in Firefox 67

Status

()

enhancement
P3
normal
RESOLVED FIXED
4 months ago
3 months ago

People

(Reporter: dao, Assigned: f20160385, Mentored)

Tracking

(Blocks 1 bug, {good-first-bug})

Trunk
Firefox 68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox66 wontfix, firefox67 fixed, firefox68 fixed)

Details

(Whiteboard: [lang=css])

Attachments

(1 attachment, 2 obsolete attachments)

Duplicate of this bug: 1533286

Hi, I want to work on this. Please assign this to me.

Assignee: nobody → khyati.agarwalss

bug 1533290 - Stop using --panel-disabled-color for subviewbutton shortcuts (where the subviewbutton is also a menuitem)

Attachment #9054092 - Attachment is obsolete: true

bug 1533290 - Stop using --panel-disabled-color for subviewbutton shortcuts (where the subviewbutton is also a menuitem)

Attachment #9054096 - Attachment is obsolete: true

Stop using --panel-disabled-color for subviewbutton shortcuts (where the subviewbutton is also a menuitem)

Can I be assigned to this bug? Please check my uploaded patch.

Flags: needinfo?(dao+bmo)
Assignee: khyati.agarwalss → f20160385
Flags: needinfo?(dao+bmo)
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1dbcf9b88e89
Stop using --panel-disabled-color for subviewbutton shortcuts (where the subviewbutton is also a menuitem) r=dao
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68

Dao, is that CSS fix something you would like to uplift to beta? Thanks

Flags: needinfo?(dao+bmo)

Comment on attachment 9054717 [details]
bug 1533290 - Stop using --panel-disabled-color for subviewbutton shortcuts (where the subviewbutton is also a menuitem)

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: bug 1520522
  • User impact if declined: keyboard shortcuts in the bookmarks menu are hard to see on Mac
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: -
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Trivial fix
  • String changes made/needed: -
Flags: needinfo?(dao+bmo)
Attachment #9054717 - Flags: approval-mozilla-beta?

Comment on attachment 9054717 [details]
bug 1533290 - Stop using --panel-disabled-color for subviewbutton shortcuts (where the subviewbutton is also a menuitem)

Trivial CSS fix fixing a visual contract issue on macos, uplift approved for 76 beta 9, thanks.

Attachment #9054717 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.