Stop using --panel-disabled-color for subviewbutton shortcuts (where the subviewbutton is also a menuitem)
Categories
(Firefox :: Theme, enhancement, P3)
Tracking
()
People
(Reporter: dao, Assigned: f20160385, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [lang=css])
Attachments
(1 file, 2 obsolete files)
47 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details | Review |
+++ This bug was initially created as a clone of Bug #1521231 +++
Followup to bug 1521231, from bug 1520522 comment 8.
To fix this, we need to remove this line:
Comment 2•6 years ago
|
||
Hi, I want to work on this. Please assign this to me.
Reporter | ||
Updated•6 years ago
|
Assignee | ||
Comment 3•6 years ago
|
||
bug 1533290 - Stop using --panel-disabled-color for subviewbutton shortcuts (where the subviewbutton is also a menuitem)
Updated•6 years ago
|
Assignee | ||
Comment 4•6 years ago
|
||
bug 1533290 - Stop using --panel-disabled-color for subviewbutton shortcuts (where the subviewbutton is also a menuitem)
Updated•6 years ago
|
Assignee | ||
Comment 5•6 years ago
|
||
Stop using --panel-disabled-color for subviewbutton shortcuts (where the subviewbutton is also a menuitem)
Assignee | ||
Comment 6•6 years ago
|
||
Can I be assigned to this bug? Please check my uploaded patch.
Reporter | ||
Updated•6 years ago
|
Comment 8•6 years ago
|
||
bugherder |
Comment 9•6 years ago
|
||
Dao, is that CSS fix something you would like to uplift to beta? Thanks
Reporter | ||
Comment 10•6 years ago
|
||
Comment on attachment 9054717 [details]
bug 1533290 - Stop using --panel-disabled-color for subviewbutton shortcuts (where the subviewbutton is also a menuitem)
Beta/Release Uplift Approval Request
- Feature/Bug causing the regression: bug 1520522
- User impact if declined: keyboard shortcuts in the bookmarks menu are hard to see on Mac
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: -
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Trivial fix
- String changes made/needed: -
Reporter | ||
Updated•6 years ago
|
Comment 11•6 years ago
|
||
Comment on attachment 9054717 [details]
bug 1533290 - Stop using --panel-disabled-color for subviewbutton shortcuts (where the subviewbutton is also a menuitem)
Trivial CSS fix fixing a visual contract issue on macos, uplift approved for 76 beta 9, thanks.
Comment 12•6 years ago
|
||
bugherder uplift |
Description
•