1533290 - Stop using --panel-disabled-color for subviewbutton shortcuts (where the subviewbutton is also a menuitem)

Status: RESOLVED FIXED

(Firefox :: Theme, enhancement, P3)

Description

[Dão Gottwald [:dao]]

+++ This bug was initially created as a clone of Bug #1521231 +++

Followup to bug 1521231, from bug 1520522 comment 8.

To fix this, we need to remove this line:

https://searchfox.org/mozilla-central/rev/fbb251448feb7276f9b1d0a88f9c0cb1cd144ce4/browser/themes/shared/customizableui/panelUI.inc.css#1176

Comment 2

[khyati.agarwalss]

Hi, I want to work on this. Please assign this to me.

Comment 3

[Khyati Agarwal]

Attachment: bug 1533290 - Stop using --panel-disabled-color for subviewbutton shortcuts (where the subviewbutton is also a menuitem)

bug 1533290 - Stop using --panel-disabled-color for subviewbutton shortcuts (where the subviewbutton is also a menuitem)

Comment 4

[Khyati Agarwal]

Attachment: bug 1533290 - Stop using --panel-disabled-color for subviewbutton shortcuts (where the subviewbutton is also a menuitem)

bug 1533290 - Stop using --panel-disabled-color for subviewbutton shortcuts (where the subviewbutton is also a menuitem)

Comment 5

[Khyati Agarwal]

Attachment: bug 1533290 - Stop using --panel-disabled-color for subviewbutton shortcuts (where the subviewbutton is also a menuitem)

Stop using --panel-disabled-color for subviewbutton shortcuts (where the subviewbutton is also a menuitem)

Comment 6

[Khyati Agarwal]

Can I be assigned to this bug? Please check my uploaded patch.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1dbcf9b88e89
Stop using --panel-disabled-color for subviewbutton shortcuts (where the subviewbutton is also a menuitem) r=dao

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/1dbcf9b88e89

Comment 9

[Pascal Chevrel (relman team) -> :pascalc]

Dao, is that CSS fix something you would like to uplift to beta? Thanks

Comment 10

[Dão Gottwald [:dao]]

Comment on attachment 9054717 [details]
bug 1533290 - Stop using --panel-disabled-color for subviewbutton shortcuts (where the subviewbutton is also a menuitem)

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: bug 1520522
• User impact if declined: keyboard shortcuts in the bookmarks menu are hard to see on Mac
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: -
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial fix
• String changes made/needed: -

Comment 11

[Pascal Chevrel (relman team) -> :pascalc]

Comment on attachment 9054717 [details]
bug 1533290 - Stop using --panel-disabled-color for subviewbutton shortcuts (where the subviewbutton is also a menuitem)

Trivial CSS fix fixing a visual contract issue on macos, uplift approved for 76 beta 9, thanks.

Comment 12

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/releases/mozilla-beta/rev/11a26a76e494