Closed Bug 1533411 Opened 5 years ago Closed 5 years ago

Crash in [@ webrender_bindings::moz2d_renderer::{{impl}}::update]

Categories

(Core :: Web Painting, defect)

Unspecified
Windows 10
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox-esr60 --- unaffected
firefox66 --- unaffected
firefox67 + fixed

People

(Reporter: marcia, Assigned: mattwoodrow)

References

Details

(Keywords: crash, regression)

Crash Data

This bug is for crash report bp-4014535c-baa2-4772-bbaa-511690190306.

Seen while looking at Nightly crash stats - small spike which started in Build 20190306095759: https://bit.ly/2C8hVP8. 27 crashes/8 installs so far, all Win 10.

Pushlog with possible regression range based on Build ID: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=78601cacfe69dc8659c3fe7cd3eb94366aa3d680&tochange=4ab143dde4dc3424cfedc74b3648fbf2e47fb7bf

Top 10 frames of crashing thread:

0 xul.dll MOZ_Crash mfbt/Assertions.h:314
1 xul.dll GeckoCrash toolkit/xre/nsAppRunner.cpp:5239
2 xul.dll static void gkrust_shared::panic_hook toolkit/library/rust/shared/lib.rs:234
3 xul.dll static void core::ops::function::Fn::call<fn src/libcore/ops/function.rs:78
4 xul.dll static void std::panicking::rust_panic_with_hook src/libstd/panicking.rs:495
5 xul.dll static <NoType> std::panicking::begin_panic<str*> src/libstd/panicking.rs:425
6 xul.dll static void webrender_bindings::moz2d_renderer::{{impl}}::update gfx/webrender_bindings/src/moz2d_renderer.rs
7 xul.dll static void webrender::resource_cache::ResourceCache::pre_scene_building_update gfx/wr/webrender/src/resource_cache.rs:630
8 xul.dll static bool webrender::render_backend::RenderBackend::process_api_msg gfx/wr/webrender/src/render_backend.rs:1176
9 xul.dll static void webrender::render_backend::RenderBackend::run gfx/wr/webrender/src/render_backend.rs:934

The crash reasons for the recent crashes are a mix of:
assertion failed: old_reader.cache.is_empty()
and
assertion failed: old.bounds.contained_by(&dirty_rect)

Bug 1496843 is a prior crash with a similar assertion.

See Also: → 1496843

Tracking for 67, out of the 40 crashes that spiked this week, 35 were on Windows 10 + Nvidia which is the os/hardware combination we are targetting for WR v1 in 67.

I can reproduce this crash consistently while viewing graphs in Google Analytics.

My crash has a different signature:
<webrender_bindings::moz2d_renderer::Moz2dBlobImageHandler as webrender_api::image::BlobImageHandler>::update

Adding the crash signature from comment 5. It looks like that signature is on OSX and Linux.

Crash Signature: [@ webrender_bindings::moz2d_renderer::{{impl}}::update] → [@ webrender_bindings::moz2d_renderer::{{impl}}::update] [@ <webrender_bindings::moz2d_renderer::Moz2dBlobImageHandler as webrender_api::image::BlobImageHandler>::update ]

If someone wishes to narrow down a test-case, you can visit the Analytics demo account at:
https://support.google.com/analytics/answer/6367342#access
(requires Google login)

Then, move the cursor over the graph. It should crash immediately.

Fixed by bug 1533317, already in today's nightly.

(In reply to Ori Avtalion (salty-horse) from comment #8)

Fixed by bug 1533317, already in today's nightly.

No crashes since 20190310214003, if there is no crashes by the end of the week, let's close the bug as fixed.

Component: Graphics: WebRender → Web Painting
Depends on: 1533317

Crashes stopped since 20190310214003, marking bug fixed

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Assignee: nobody → matt.woodrow
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.